Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-27 Thread via GitHub
navneet1v commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133913068 @uschindler thanks. I didn't realize it. Generally I see labels added or last time I raised the PR manually for backport. Thanks for confirming this code is merged. -- This is an au

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-27 Thread via GitHub
uschindler commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133895659 thats already merged (see above @ "asfgit pushed"). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-27 Thread via GitHub
navneet1v commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133879878 @uschindler do i need to create a separate PR for porting this change to branch_9x or there is any automated way to do this? -- This is an automated message from the Apache Git Servi

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-27 Thread via GitHub
uschindler commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133833594 Done! Thanks, @navneet1v -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-27 Thread via GitHub
uschindler merged PR #13394: URL: https://github.com/apache/lucene/pull/13394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-27 Thread via GitHub
navneet1v commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133829356 @ChrisHegarty , @uschindler can merge the code and add the backport label to backport the code to branch_9x -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-23 Thread via GitHub
navneet1v commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2127668713 @uschindler @ChrisHegarty Could you please take a look, if you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-20 Thread via GitHub
navneet1v commented on PR #13394: URL: https://github.com/apache/lucene/pull/13394#issuecomment-2121465615 cc: @benwtrent , @msokolov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-20 Thread via GitHub
navneet1v opened a new pull request, #13394: URL: https://github.com/apache/lucene/pull/13394 ### Description Add support for reloading the SPI for KnnVectorsFormat class Ref: https://github.com/apache/lucene/issues/13393 -- This is an automated message from the Apache Gi