uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2025086037
> As disussed before, for implementing fadvise for reading/writing files, we
would need to write a full stack of IO layer natively (OutputStream for writing
and FileChannel for NIOFSD
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2020051067
Anyways we can open an issue to track what's going on on the JDK (listing
all relevant issue numbers like the above one).
--
This is an automated message from the Apache Git Service
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2020039697
As disussed before, for implementing fadvise for reading/writing files, we
would need to write a full stack of IO layer natively (OutputStream for writing
and FileChannel for NIOFSDir
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2020036092
Unfortunately fadvise is at moment close to impossible. Reason: we have no
file handle!
Chances are good that we also get a Java-based fadvise some time in the
future (e.g., th
jpountz commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2020031076
@uschindler Should we open a separate issue for adding `fadvise` support to
`NIOFSDirectory`?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
ChrisHegarty commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2020022627
I dunno what I was thinking, this is clearly not correct. I opened #13214 to
fix the test. ( apologies for the stupid test issues! )
--
This is an automated message from the Apach
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2019973001
> > The test added by @ChrisHegarty sometimes fails on windows: It does not
close the file it opened for random access testing, so the directory can't be
deleted. Will fix this in a s
ChrisHegarty commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2019923997
> The test added by @ChrisHegarty sometimes fails on windows: It does not
close the file it opened for random access testing, so the directory can't be
deleted. Will fix this in a s
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2019919116
I also removed the extra logging included while development from the main
branch. In 9.x the log message was adapted to list both features together with
the sysprop to disable).
--
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2018772367
I fixed the test in
https://github.com/apache/lucene/commit/ae5d3534e3ef44ff3336dea0308d8a82f0672ff2
--
This is an automated message from the Apache Git Service.
To respond to the m
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2018749550
The test added by @ChrisHegarty sometimes fails on windows: It does not
close the file it opened for random access testing, so the directory can't be
deleted. Will fix this in a separ
uschindler merged PR #13196:
URL: https://github.com/apache/lucene/pull/13196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2018328574
@jpountz Are you fine with merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2016797422
Maybe it is easier to see results on benchmarking when it is in main branch.
I am waiting for final review by @jpountz and then merge this. Backporting to
9.x is also planned and shou
14 matches
Mail list logo
