Re: [PR] Add sub query explanations in DisjunctionMaxQuery#explain on no-match [lucene]

2024-05-14 Thread via GitHub
jpountz merged PR #13362: URL: https://github.com/apache/lucene/pull/13362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add sub query explanations in DisjunctionMaxQuery#explain on no-match [lucene]

2024-05-14 Thread via GitHub
timgrein commented on PR #13362: URL: https://github.com/apache/lucene/pull/13362#issuecomment-2110435055 Thanks for the reviews! Added it to the improvement section ✅ @jpountz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add sub query explanations in DisjunctionMaxQuery#explain on no-match [lucene]

2024-05-14 Thread via GitHub
timgrein commented on PR #13362: URL: https://github.com/apache/lucene/pull/13362#issuecomment-2110260612 > This could make explanations harder to read for large queries, e.g. queries produced through rewriting. I wonder about doing something in-between such as only including the non-matchi

Re: [PR] Add sub query explanations in DisjunctionMaxQuery#explain on no-match [lucene]

2024-05-14 Thread via GitHub
jpountz commented on PR #13362: URL: https://github.com/apache/lucene/pull/13362#issuecomment-2110112272 This could make explanations harder to read for large queries, e.g. queries produced through rewriting. I wonder about doing something in-between such as only including the non-matching