github-actions[bot] commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2649549901
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
rmuir commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2616629072
I will look in on the ECJ side, last time I used it, their null analysis had
issues on lucene's enormous codebase. It was many years ago though, maybe it
has solidified.
error-prone
rmuir commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2616604765
One option we could do for correctness is to turn on ecj's null analysis.
ecj is pretty fast and runs as part of gradle checks already, and it is the
compiler often using this feature in t
msokolov commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2616198970
> Specifying that something is nullable doesn't provide any value: all types
are nullable by default already.
I guess these null-checking systems impose their own assumptions and
rmuir commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2616174314
For the java language:
Specifying that something is nullable doesn't provide any value: all types
are nullable by default already.
Specifying that something is NOT-nullable wo
msokolov commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2615754639
This seems reasonable to me, but it implies a future promise to maintain it,
and I don't know how we would ever know if we added some new usage that isn't
properly annotated
--
This
github-actions[bot] commented on PR #14132:
URL: https://github.com/apache/lucene/pull/14132#issuecomment-2613644568
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
Edarke opened a new pull request, #14132:
URL: https://github.com/apache/lucene/pull/14132
Annotate public APIs with an internal definition of `@Nullable` where
appropriate.
This proposal is a follow up from the discussion
[here](https://lists.apache.org/thread/oh09k7nlvntzf49gx7d399
