Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-09 Thread via GitHub
benwtrent merged PR #13181: URL: https://github.com/apache/lucene/pull/13181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-08 Thread via GitHub
ChrisHegarty commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1593562581 ## lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java: ## @@ -75,4 +76,14 @@ public static void checkField(LeafReader in, String field) {

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-07 Thread via GitHub
benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1593083585 ## lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java: ## @@ -75,4 +76,14 @@ public static void checkField(LeafReader in, String field) {

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-07 Thread via GitHub
msokolov commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1593061701 ## lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java: ## @@ -75,4 +76,14 @@ public static void checkField(LeafReader in, String field) {

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-07 Thread via GitHub
benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1593056612 ## lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java: ## @@ -75,4 +76,14 @@ public static void checkField(LeafReader in, String field) {

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-07 Thread via GitHub
ChrisHegarty commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1592707341 ## lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java: ## @@ -75,4 +76,14 @@ public static void checkField(LeafReader in, String field) {

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-07 Thread via GitHub
ChrisHegarty commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1592707341 ## lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java: ## @@ -75,4 +76,14 @@ public static void checkField(LeafReader in, String field) {

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-03 Thread via GitHub
benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1589212230 ## lucene/core/src/java/org/apache/lucene/search/VectorScorer.java: ## @@ -18,64 +18,39 @@ import java.io.IOException; import org.apache.lucene.index.ByteVectorV

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-02 Thread via GitHub
benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1587957013 ## lucene/core/src/java/org/apache/lucene/util/quantization/QuantizedByteVectorValues.java: ## @@ -18,13 +18,40 @@ import java.io.IOException; import org.apache.

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-02 Thread via GitHub
benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1587945011 ## lucene/core/src/java/org/apache/lucene/search/VectorScorer.java: ## @@ -18,64 +18,39 @@ import java.io.IOException; import org.apache.lucene.index.ByteVectorV

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-02 Thread via GitHub
msokolov commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1587804525 ## lucene/core/src/java/org/apache/lucene/util/quantization/QuantizedByteVectorValues.java: ## @@ -18,13 +18,40 @@ import java.io.IOException; import org.apache.l

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-05-01 Thread via GitHub
benwtrent commented on PR #13181: URL: https://github.com/apache/lucene/pull/13181#issuecomment-2088865803 This is my first attempt at a new interface for exact search. We are missing performance improvements through quantization and have a fairly complex API for exact search, requiri

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-03-14 Thread via GitHub
benwtrent commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1525282411 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -190,12 +190,13 @@ protected TopDocs exactSearch(LeafReaderContext context, DocI

Re: [PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-03-14 Thread via GitHub
mccullocht commented on code in PR #13181: URL: https://github.com/apache/lucene/pull/13181#discussion_r1525162554 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -190,12 +190,13 @@ protected TopDocs exactSearch(LeafReaderContext context, Doc

[PR] Add new VectorScorer interface to vector value iterators [lucene]

2024-03-13 Thread via GitHub
benwtrent opened a new pull request, #13181: URL: https://github.com/apache/lucene/pull/13181 With quantized vectors, and with current vectors, we separate out the "scoring" vs. "iteration", requiring the user to always iterate the raw vectors and provide their own similarity function.