Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-27 Thread via GitHub
mkhludnev commented on PR #13077: URL: https://github.com/apache/lucene/pull/13077#issuecomment-1966073356 aaahgg... wrong CHANGES.. going to move in unde 9.11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-27 Thread via GitHub
mkhludnev merged PR #13077: URL: https://github.com/apache/lucene/pull/13077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-12 Thread via GitHub
AndreyBozhko commented on PR #13077: URL: https://github.com/apache/lucene/pull/13077#issuecomment-1938870965 Checks are failing due to unrelated error from 314c553bdce22bc1bc08e46b218691575c2287e0: ``` Deprecated is not a repeatable annotation type @Deprecated public static final

Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-12 Thread via GitHub
AndreyBozhko commented on PR #13077: URL: https://github.com/apache/lucene/pull/13077#issuecomment-1938846917 @mkhludnev Makes sense - I added a simple test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-10 Thread via GitHub
mkhludnev commented on PR #13077: URL: https://github.com/apache/lucene/pull/13077#issuecomment-1937082685 Thanks. It's probably worth to refer to this method from a test to further prevent its' sudden drop from the API. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-08 Thread via GitHub
AndreyBozhko commented on PR #13077: URL: https://github.com/apache/lucene/pull/13077#issuecomment-1935333285 @dungba88 If all looks good, please feel free to merge this at your earliest convenience (as I don't have access to do so myself). -- This is an automated message from the Apache

Re: [PR] Add getter for SynonymQuery#field [lucene]

2024-02-05 Thread via GitHub
AndreyBozhko commented on PR #13077: URL: https://github.com/apache/lucene/pull/13077#issuecomment-1928773466 Thanks for the review @dungba88 - I added the javadoc as well (tried to match the style of other javadocs in the file). -- This is an automated message from the Apache Git Service

[PR] Add getter for SynonymQuery#field [lucene]

2024-02-05 Thread via GitHub
AndreyBozhko opened a new pull request, #13077: URL: https://github.com/apache/lucene/pull/13077 ### Description Since all the query terms must have the same field, the value is exposed anyway via ```java synonymQuery.getTerms().get(0).field() ``` but it's cleaner if o