stefanvodita commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1752721942
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -0,0 +1,276 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stefanvodita commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1752721942
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -0,0 +1,276 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stefanvodita merged PR #13689:
URL: https://github.com/apache/lucene/pull/13689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
stefanvodita commented on PR #13689:
URL: https://github.com/apache/lucene/pull/13689#issuecomment-2341420365
I've addressed the feedback and there don't seem to be any blockers. Thank
you Mike and Robert for reviewing!
--
This is an automated message from the Apache Git Service.
To respo
stefanvodita commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1748216227
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -0,0 +1,276 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stefanvodita commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1748213889
##
lucene/demo/src/java/org/apache/lucene/demo/facet/DynamicRangeFacetsExample.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mikemccand commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1745595485
##
lucene/demo/src/java/org/apache/lucene/demo/facet/package-info.java:
##
@@ -385,6 +385,12 @@
* Sampling support is implemented in {@link
* org.apache.lucene.
stefanvodita commented on PR #13689:
URL: https://github.com/apache/lucene/pull/13689#issuecomment-2329719474
It would be great to merge this in time for 9.12. Since it's completely new
code and marked experimental, I don't expect it to be controversial, but I'll
wait a bit longer in case a
