Re: [PR] Add a method allowing canonical strings to be returned from DataInput [lucene]

2023-11-02 Thread via GitHub
mikemccand closed pull request #11847: Add a method allowing canonical strings to be returned from DataInput URL: https://github.com/apache/lucene/pull/11847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Add a method allowing canonical strings to be returned from DataInput [lucene]

2023-11-02 Thread via GitHub
mikemccand commented on PR #11847: URL: https://github.com/apache/lucene/pull/11847#issuecomment-1790607699 It looks like there are strong objections to sharing string instances here, and there is a JVM command-line flag that may achieve similar gains for many indices X segments X fields so

Re: [PR] Add a method allowing canonical strings to be returned from DataInput [lucene]

2023-11-02 Thread via GitHub
mikemccand commented on code in PR #11847: URL: https://github.com/apache/lucene/pull/11847#discussion_r1380002867 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -145,8 +145,10 @@ public FieldInfos read( // previous field'