Re: [PR] Add KeywordField and StringValueFacetCounts example [lucene]

2023-11-22 Thread via GitHub
stefanvodita commented on PR #12817: URL: https://github.com/apache/lucene/pull/12817#issuecomment-1823134763 Thank you @msokolov! I pushed a [commit](https://github.com/stefanvodita/lucene/commit/0b7498fe1af9ccb7a71df79655b3e3dbff3b253f) with a CHANGES entry. Do you need me to open a PR ag

Re: [PR] Add KeywordField and StringValueFacetCounts example [lucene]

2023-11-22 Thread via GitHub
msokolov commented on PR #12817: URL: https://github.com/apache/lucene/pull/12817#issuecomment-1823101661 It just occurred to me; perhaps we should add a CHANGE log entry? And it could be nice to backport to 9.x if you like -- This is an automated message from the Apache Git Service. To r

Re: [PR] Add KeywordField and StringValueFacetCounts example [lucene]

2023-11-22 Thread via GitHub
msokolov merged PR #12817: URL: https://github.com/apache/lucene/pull/12817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[PR] Add KeywordField and StringValueFacetCounts example [lucene]

2023-11-16 Thread via GitHub
stefanvodita opened a new pull request, #12817: URL: https://github.com/apache/lucene/pull/12817 We don't have a demo for faceting using `KeywordField`, `SortedDocValuesField`, or `StringValueFacetCounts`. This PR adds one, mostly inspired by `SimpleSortedSetFacetsExample`. -- This i