shubhamvishu commented on PR #12548:
URL: https://github.com/apache/lucene/pull/12548#issuecomment-1761428061
@msokolov @benwtrent Raised a followup PR #12671 for this and also moved
some other relevant static classes etc out of DVS(it now looks much better to
me). Thanks!
--
This is an
shubhamvishu commented on code in PR #12548:
URL: https://github.com/apache/lucene/pull/12548#discussion_r1357312134
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -172,6 +173,52 @@ public LongValuesSource rewrite(IndexSearcher searcher)
throws
msokolov commented on code in PR #12548:
URL: https://github.com/apache/lucene/pull/12548#discussion_r1357190877
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -172,6 +173,52 @@ public LongValuesSource rewrite(IndexSearcher searcher)
throws IOEx
benwtrent merged PR #12548:
URL: https://github.com/apache/lucene/pull/12548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on PR #12548:
URL: https://github.com/apache/lucene/pull/12548#issuecomment-1760058838
These are good ideas @msokolov , @shubhamvishu a follow up PR is most
welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
shubhamvishu commented on code in PR #12548:
URL: https://github.com/apache/lucene/pull/12548#discussion_r1357050474
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -172,6 +173,52 @@ public LongValuesSource rewrite(IndexSearcher searcher)
throws
shubhamvishu commented on code in PR #12548:
URL: https://github.com/apache/lucene/pull/12548#discussion_r1357050474
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -172,6 +173,52 @@ public LongValuesSource rewrite(IndexSearcher searcher)
throws
shubhamvishu commented on PR #12548:
URL: https://github.com/apache/lucene/pull/12548#issuecomment-1759892123
> oh I missed that @benwtrent had approved -- it's OK w/me to merge as-is,
just had some idea about organizing the static methods into a different class...
Thanks @msokolov !
msokolov commented on PR #12548:
URL: https://github.com/apache/lucene/pull/12548#issuecomment-1759887696
oh I missed that @benwtrent had approved -- it's OK w/me to merge as-is,
just had some idea about organizing the static methods into a different class...
--
This is an automated messa
msokolov commented on code in PR #12548:
URL: https://github.com/apache/lucene/pull/12548#discussion_r1357027508
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -172,6 +173,52 @@ public LongValuesSource rewrite(IndexSearcher searcher)
throws IOEx
benwtrent commented on PR #12548:
URL: https://github.com/apache/lucene/pull/12548#issuecomment-1759701427
@shubhamvishu running CI :). I will see about merging and such soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
shubhamvishu commented on PR #12548:
URL: https://github.com/apache/lucene/pull/12548#issuecomment-1759689286
Thanks for reviewing!
@benwtrent I have added a CHANGES.txt entry now, could you help me merging
this if all looks good?
--
This is an automated message from the Apache Gi
stefanvodita commented on code in PR #12548:
URL: https://github.com/apache/lucene/pull/12548#discussion_r1347266594
##
lucene/core/src/java/org/apache/lucene/search/FloatVectorSimilarityValuesSource.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (
13 matches
Mail list logo
