rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2843493667
Thank you for solving this one @dweiss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
rmuir closed issue #14490: update PRs for java dependencies
URL: https://github.com/apache/lucene/issues/14490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2843328050
Should we close this, @rmuir ? Seems to be working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804025900
Thanks for hacking at this one, I appreciate it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804159900
I see your point: I see it from your fork at the expected place that
requires no special permissions:
https://github.com/dweiss/lucene/network/dependencies?q=ecosystem%3AMaven
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804947353
I've merged this on main. Let's see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804005231
Let me take a look on my fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2803979497
@dweiss mainly I am curious if we can see the new dependencies under
https://github.com/apache/lucene/network/dependencies
I don't know how to test this (i think it only evals d
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804189280
This is I think the least invasive change:
https://github.com/apache/lucene/pull/14495
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804184837
> I dont know what this "Github Dependency Graph Gradle Plugin" is doing at
all
I think it's computing a dependency graph inside gradle, then submitting it
to github via their
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804108791
Ok, so I think that:
- adding gradle dependencies requires moving the catalog, it's a simple
change and is fine,
- we get update PRs for free then
- adding dependency graph r
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804115889
Here is why I think adding dependency graph will require some filtering -
these reports very likely originate from gradle plugins somewhere. It's hard to
even track them down:
ht
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804123037
> Here is why I think adding dependency graph will require some filtering -
these reports very likely originate from gradle plugins somewhere. It's hard to
even track them down:
>
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804120377
Is the catalog treated separately than the ordinary java library deps (e.g.
commons-whatever)? Ideally we bring all the deps into automation, but for this
issue I figured the java lib
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804061293
I don't think the dependency graph supports gradle out of the box -
https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/depe
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804071176
The documentation for dependency submission action is here:
https://github.com/gradle/actions/blob/main/docs/dependency-submission.md
it is verbose. I'm not sure we need to u
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804036034
Can't see the dependencies in gradle ecosystem here, perhaps yet:
https://github.com/dweiss/lucene/network/dependencies
but something did run:
https://github.com/dweiss/lucen
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2803967384
I'm not actively working this yet, it is just for discussion. But if we can
coerce the thing to work well with our project, I think it is beneficial.
Better to have a failing PR, well
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2803968903
I think the "gradle convention" is to keep libs.version.toml under gradle/
and I think it's what dependabot understands - and I personally hate this,
without any specific objective r
rmuir opened a new issue, #14490:
URL: https://github.com/apache/lucene/issues/14490
### Description
I added dependabot.yml in https://github.com/apache/lucene/pull/14462
Currently it sends us pull requests for:
- github actions
- pip dependencies in `dev-tools/`
Bu
20 matches
Mail list logo
