Re: [I] testMergeStability failing for Knn formats [lucene]

2025-01-29 Thread via GitHub
benwtrent closed issue #13640: testMergeStability failing for Knn formats URL: https://github.com/apache/lucene/issues/13640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] testMergeStability failing for Knn formats [lucene]

2025-01-28 Thread via GitHub
benwtrent commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2620151180 Interesting, the randomized case isn't anything special. Its just a plain 'ole Lucene99Hnsw index. No quantization or anything :/ -- This is an automated message from the Apache

Re: [I] testMergeStability failing for Knn formats [lucene]

2025-01-28 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2619990074 I did the git bisect dance and found this test seed starts failing with [Randomize KnnVector codec params in RandomCodec](https://github.com/apache/lucene/commit/6b0112cdee284cae91

Re: [I] testMergeStability failing for Knn formats [lucene]

2025-01-28 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2619823636 Curious if you tried git bisect to see if there was any recent change that reintroduced this? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] testMergeStability failing for Knn formats [lucene]

2025-01-27 Thread via GitHub
benwtrent commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2616596850 I discovered two other weird behaviors digging into this test failure. But, neither seemed to fix this inconsistency: https://github.com/apache/lucene/pull/14174 -- Thi

[I] testMergeStability failing for Knn formats [lucene]

2025-01-27 Thread via GitHub
benwtrent opened a new issue, #13640: URL: https://github.com/apache/lucene/issues/13640 ### Description All KNN formats are periodically failing `testMergeStability`. I have verified its due to https://github.com/apache/lucene/pull/13566 The stability failure is due to

Re: [I] testMergeStability failing for Knn formats [lucene]

2025-01-27 Thread via GitHub
benwtrent commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2616417275 @msokolov its reared its head again. ``` ./gradlew test --tests TestPerFieldKnnVectorsFormat.testMergeStability -Dtests.seed=FF1182F3FC600FF -Dtests.locale=mni-Beng-IN

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-14 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2288628863 No it's not `HnswGraphBuilder` *per se* but the `HnswConcurrentMergeBuilder` that calls `finish()` and thence `connectComponents`. Since it's part of the o.a.l.u.hnsw package it's

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-14 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2288618203 See https://github.com/apache/lucene/pull/13654/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-14 Thread via GitHub
benwtrent commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2288559628 Not to be the bearer of bad news: ``` ./gradlew test --tests TestLucene95HnswVectorsFormat.testMergeStability -Dtests.seed=3D48DB65BA75CD03 -Dtests.locale=uz-Latn-UZ -Dtest

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-13 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2286271018 found and fixed a branch_9x-only problem. Hopefully this calms down now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-10 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2282219274 OK, I guess we would need to actually build a graph when merging a single segment in case there are deletions. In any case it would be nice if the graph reconnection were stable. T

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-10 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2282198464 I didn't know about this constraint until now. Basically what happens is during merge we check for disconnected components and attempt to *add* connections to connect them. So it m

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-10 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2282193339 hmm thanks I'll take a look soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-09 Thread via GitHub
benwtrent commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2278701946 @msokolov ^ I haven't been able to look into fixing it yet. Just now noticed it. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[I] testMergeStability failing for Knn formats [lucene]

2024-08-09 Thread via GitHub
benwtrent opened a new issue, #13640: URL: https://github.com/apache/lucene/issues/13640 ### Description All KNN formats are periodically failing `testMergeStability`. I have verified its due to https://github.com/apache/lucene/pull/13566 The stability failure is due to