Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-07 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2858914015 :) No, I just checked if it works locally on Linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-07 Thread via GitHub
uschindler commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2858772211 Thanks for also fixing linux spaces in pathname, Did you hit it on the s390x Jenkins node? There I added a whitespace in the workspace name!!! -- This is an automated message f

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-07 Thread via GitHub
uschindler commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2858764089 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-07 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2858176432 I've noticed that Windows gradlew.bat had a subtle bug which resulted in always triggering java checksum validation. I've fixed the problem and will let chatgpt explain it in details

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-04 Thread via GitHub
dweiss closed issue #14598: gradle-wrapper.jar will not be updated when its sha/version changes URL: https://github.com/apache/lucene/issues/14598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-04 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2849301978 https://github.com/apache/lucene/pull/14608 This adds sha256 check on Windows and Linux. The Linux part is a redesigned version of what chatgpt came up with. I believe even cha

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-04 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2849293690 This is actually a sort-of regression introduced in #13404 (90e07f666422). Previously, we'd always check the checksum of the wrapper file. After this change - to speed up startup ti

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-02 Thread via GitHub
ChrisHegarty commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2846847520 I noticed problems with the gradle wrapper also, e.g. ``` ./gradlew check no main manifest attribute, in /Users/chegar/git/lucene/gradle/wrapper/gradle-wrapper.jar `

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-04-30 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2844174816 You're right - I'm paranoid. I no longer use Windows on a regular basis but I can check on a vm later today. Like I said - if nothing else works, we can still just make Wrappe

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-04-30 Thread via GitHub
rmuir commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843482547 > I also thought about sha256sum check in gradlew - this spawns a process but doesn't seem to be too bad... Well i mean this is what shell scripts do. The current `gradlew` spa

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-04-30 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843324990 I computed the current sha256 using command-line tools byte copy-pasted it directly into Lucene sources. No magic. I also thought about sha256sum check in gradlew - this spawns

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-04-30 Thread via GitHub
rmuir commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843104515 I looked into this, there's a `gradle/wrapper/gradle-wrapper.jar.sha256` but it is not in the standard format. How is this currently being generated/used? I would propose: Gene

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-04-30 Thread via GitHub
rmuir commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843055994 I had to remove a wrapper manually this morning (maybe it was 0 bytes or corrupt or outdated) and force it to be re-downloaded myself. I didn't raise any issue as you know, i do hacky

[I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-04-30 Thread via GitHub
dweiss opened a new issue, #14598: URL: https://github.com/apache/lucene/issues/14598 ### Description Uwe noticed this. After the update to gradle 8.14, I've updated the gradle-wrapper script's version and SHA. The new scripts launch it using -jar (previously it was launched using an