jpountz closed issue #13805: TestLucene90DocValuesFormat fails with
ArrayIndexOutOfBoundsException
URL: https://github.com/apache/lucene/issues/13805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jpountz closed issue #13805: TestLucene90DocValuesFormat fails with
ArrayIndexOutOfBoundsException
URL: https://github.com/apache/lucene/issues/13805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jpountz commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2361101846
I have a fix and tests that would have found the bug at #13812.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bugmakerr commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360998233
> Separately, we may want to consider changing the DocValuesProducer API to
take a String rather than a FieldInfo, like e.g. points, so that it is not
tempted to trust the cal
ChrisHegarty commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360936290
Let's postpone the 9_12 branch cut until tomorrow, pending on the outcome of
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
jpountz commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360928625
Give me some time to see how the fix and tests look, and let's think about
whether/what to revert later on? I expect to have something by end of day.
@ChrisHegarty Feel free to cut
ChrisHegarty commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360875134
Ok, reverts are prepared. @jpountz you wanna fix (and not revert), or revert
for now?
--
This is an automated message from the Apache Git Service.
To respond to the message,
jpountz commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360854476
I found the actual root cause, it's here:
https://github.com/apache/lucene/blob/e4ac57746eb86846b3a53944c14e09873f793ff1/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsum
jpountz commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360784108
I found the bug, it's the slow composite reader wrapper which is at fault
here. I'll look into improving tests to detect such issues.
Separately, we may want to consider chang
rmuir commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360778828
yeah it would be best to improve the tests: it is not good that it took this
test, run many many times, to find it.
--
This is an automated message from the Apache Git Service.
To r
jpountz commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360763893
I don't mind reverting but I would also like to fix the root cause as this
change only exposed an existing bug: someone is calling a doc-values producer
with the wrong FieldInfo obj
ChrisHegarty commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360745810
I filed a meta issue to better track the reverts, #13809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
rmuir commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360732114
we didn't even have bulk merge at all in lucene for a couple years at all
because of field-number bugs like this. got bit too many times.
--
This is an automated message from the Ap
rmuir commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360728834
sounds like the safe bet to backout any changes messing around with
fieldinfos on merge.
Sorry for the short explanation, there is a long history of super-sneaky
corruption bug
ChrisHegarty commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360725418
The revert fixes the failures we see here and the other related test
failures, seen in #13807 #13808.
--
This is an automated message from the Apache Git Service.
To respond
benwtrent commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360701787
@ChrisHegarty this makes be worried about all the other field number switch
with field name things as well.
I am wondering if we should revert all of them, there are multip
ChrisHegarty commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360692292
I'm going to try reverting
https://github.com/apache/lucene/commit/6634b41f42f4e2802048d1e4750e1ce1202652c5.
--
This is an automated message from the Apache Git Service.
To r
jpountz commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2360238996
Argh, I remember carefully checking whether this PR could cause issues due
to mismatched field infos, but apparently I missed something.
--
This is an automated message from the A
iverase commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2359389642
See here:
https://github.com/apache/lucene/blob/6d987e1ce1c3f3215633a979ce048829fe1bb6ed/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PointsWriter.java#L248
--
T
iverase commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2359380429
Probably we are not remapping the field ordinal properly when merging
segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
benwtrent commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2359368164
git bisect might be lying, I don't see how that PR could cause this failure
:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
benwtrent commented on issue #13805:
URL: https://github.com/apache/lucene/issues/13805#issuecomment-2359326047
Git bisect puts the blame at: 6634b41f42f4e2802048d1e4750e1ce1202652c5
https://github.com/apache/lucene/pull/13686
--
This is an automated message from the Apache Git Serv
ChrisHegarty opened a new issue, #13805:
URL: https://github.com/apache/lucene/issues/13805
```
RROR: The following test(s) have failed:
-
org.apache.lucene.codecs.lucene90.TestLucene90DocValuesFormat.testSparseDocValuesVsStoredFields
(:lucene:core)
Test output:
/opt/bui
23 matches
Mail list logo
