Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-11-03 Thread via GitHub
dweiss commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1792205263 Thanks, Simon. I'll open up a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-11-03 Thread via GitHub
s1monw commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1792101597 @dweiss I agree this is the problem. We should execute that `IOUtils.closeWhileHandlingException(readerPool, deleter, writeLock);` in a try / finally block. I can open a PR for that

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-11-02 Thread via GitHub
dweiss commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1791521460 In fact, I think it's this block in IW: ``` // close all the closeables we can (but important is readerPool and writeLock to prevent // leaks)

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-11-02 Thread via GitHub
dweiss commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1791510733 This may be a legitimate bug somewhere. Maybe @mikemccand or @s1monw will know what the expected state here should be. -- This is an automated message from the Apache Git Service.

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-11-02 Thread via GitHub
dweiss commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1791500183 You can reproduce this problem from the IDE as well: ``` -ea -Dtests.seed=4A059D04FCC8873 -Dtests.nightly=true -Dtests.multiplier=1 -Dtests.verbose=true ``` The last messa

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-11-02 Thread via GitHub
dweiss commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1791471920 Well, this test is almost never "fast" for me... the conditions passed in Failure.eval are frequently called, but rarely hit the right call stack - this is particularly problematic w

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-10-11 Thread via GitHub
benwtrent commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1757926532 ``` final int numIterations = TEST_NIGHTLY ? atLeast(100) : atLeast(5); ``` Is one such place where `nightly` matters from what I can tell. I verified the `139`

Re: [I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-10-11 Thread via GitHub
benwtrent commented on issue #12654: URL: https://github.com/apache/lucene/issues/12654#issuecomment-1757910972 Added some println statements to ``` public void eval(MockDirectoryWrapper dir) throws IOException { if (r.nextInt(3000) == 0) { if (callStackC

[I] TestIndexWriterOnVMError.testUnknownError timesout [lucene]

2023-10-11 Thread via GitHub
benwtrent opened a new issue, #12654: URL: https://github.com/apache/lucene/issues/12654 ### Description CI indicated the test suite timed out. So, I ran the reproduction line locally and had to kill the test running after 5 minutes. I seriously doubt this test should take long