Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-08-07 Thread via GitHub
benwtrent closed issue #13127: TestIDVersionPostingsFormat failure URL: https://github.com/apache/lucene/issues/13127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-08-07 Thread via GitHub
benwtrent closed issue #13127: TestIDVersionPostingsFormat failure URL: https://github.com/apache/lucene/issues/13127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-08-01 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-2264299983 Ah, another option is to switch the logic that is used to mark it free and send it back to the freeList. We can check if the deleteQueue is advanced, and just unlock it instead of

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-08-01 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-2264281268 Another option is continue to lock after the deleteQueue generation creation until the DWPT are removed. -- This is an automated message from the Apache Git Service. To respond

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-08-01 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-2264278817 Yeah, looking at `markForFullFlush`, it seems like we mark the generation to gather that `seqNo`, then unlock DWFC, and this allows new DWPT to be returned with the old generation

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-08-01 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-2264272195 OK, I added a bunch of logging and it seems like the issue is around `DWPTP#getAndLock`. I can see the following occurring, new DWPTs being created, each with the first ge

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-03-14 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-1998480248 More investigation is needed. The only other method that updates `DWDQ#nextSeqNo` is `DWDQ#skipSequenceNumbers(long)`. The only place that `DWDQ#skipSequenceNumbers(long)` i

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-03-14 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-1998402170 Well, that race-condition wasn't the cause. I have seen another failure. ``` ./gradlew test --tests TestIDVersionPostingsFormat.testGlobalVersions -Dtests.seed=DEC45C861B1BCF

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-03-12 Thread via GitHub
benwtrent closed issue #13127: TestIDVersionPostingsFormat failure URL: https://github.com/apache/lucene/issues/13127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-03-08 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-1986327081 OK, looking at where they are used, it seems like they were attempted to be synchronized, but we aren't synchronizing on the same things, which could cause a race condition.

Re: [I] TestIDVersionPostingsFormat failure [lucene]

2024-03-08 Thread via GitHub
benwtrent commented on issue #13127: URL: https://github.com/apache/lucene/issues/13127#issuecomment-1986293179 Looking at the code in `DocumentsWriterDeleteQueue#close()`, we trip if `seqNo` is ever larger than `maxSeqNo`. `maxSeqNo` is set in `DocumentsWriterDeleteQueue#advanceQueu

[I] TestIDVersionPostingsFormat failure [lucene]

2024-02-21 Thread via GitHub
jpountz opened a new issue, #13127: URL: https://github.com/apache/lucene/issues/13127 ### Description This failure is not reproducible, which is maybe not too surprising given that the test involves concurrency. A few things are interesting: - This is the same failure I had got o