Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
jpountz commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864480721 I just pushed the change, thanks @mikemccand for putting me on the right track. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
jpountz closed issue #12957: Reproducible test failure with Terms#intersect on the default codec URL: https://github.com/apache/lucene/issues/12957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
mikemccand commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864450920 OK the `DirectPostingsFormat` failure is also happy with this fix. +1 to merge. Thanks @jpountz! -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
mikemccand commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864448812 > > Terms.intersect(Automaton a, BytesRef startTerm) requires that startTerm is accepted by the incoming automaton, yet the way CheckIndex is calling it can clearly violate that.

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
jpountz commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864407118 Oh I see, I created binary automata, but the API implicitly treats automata as UTF32 automata, so you need to tell it explicitly that it's a binary automaton. And something like tha

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
jpountz commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864395031 > Terms.intersect(Automaton a, BytesRef startTerm) requires that startTerm is accepted by the incoming automaton, yet the way CheckIndex is calling it can clearly violate that.

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
mikemccand commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864386831 I'll try to fix `CheckIndex` so that it only uses `startTerm` that is accepted by the automaton. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
mikemccand commented on issue #12957: URL: https://github.com/apache/lucene/issues/12957#issuecomment-1864385415 OK I think the issue here may be that `Terms.intersect(Automaton a, BytesRef startTerm)` requires that `startTerm` is accepted by the incoming automaton, yet the way `CheckIndex`

[I] Reproducible test failure with Terms#intersect on the default codec [lucene]

2023-12-20 Thread via GitHub
jpountz opened a new issue, #12957: URL: https://github.com/apache/lucene/issues/12957 ### Description The new CheckIndex checks are causing some test failures with the default codec, which are reproducible and look like real bugs? I started looking but I'm not familiar enough with B