Re: [I] Remove Scorer#getWeight. [lucene]

2024-06-06 Thread via GitHub
jpountz closed issue #13410: Remove Scorer#getWeight. URL: https://github.com/apache/lucene/issues/13410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Remove Scorer#getWeight. [lucene]

2024-05-27 Thread via GitHub
jpountz commented on issue #13410: URL: https://github.com/apache/lucene/issues/13410#issuecomment-2132905389 @navneet1v Since a `Scorer` must be created from a `Weight`, callers would be expected to keep track of the `Weight` that created the `Scorer` if they need it instead of relying on

Re: [I] Remove Scorer#getWeight. [lucene]

2024-05-25 Thread via GitHub
romseygeek commented on issue #13410: URL: https://github.com/apache/lucene/issues/13410#issuecomment-2131369881 +1 I'd also look at removing Scorable.getChildren() which we use in a few tests in tandem with getWeight(). We now have several composite scorer implementations that don'

Re: [I] Remove Scorer#getWeight. [lucene]

2024-05-24 Thread via GitHub
navneet1v commented on issue #13410: URL: https://github.com/apache/lucene/issues/13410#issuecomment-2130159284 @jpountz what would be the alternative to `getWeight` function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[I] Remove Scorer#getWeight. [lucene]

2024-05-24 Thread via GitHub
jpountz opened a new issue, #13410: URL: https://github.com/apache/lucene/issues/13410 ### Description I've been working on some refactorings recently, and the fact that `Scorer` has a `getWeight` method is very annoying as it requires every simple `Scorer` implementation, e.g. for t