dweiss closed issue #13820: DataInput class can't be used with delegation
pattern
URL: https://github.com/apache/lucene/issues/13820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dweiss commented on issue #13820:
URL: https://github.com/apache/lucene/issues/13820#issuecomment-2375077701
I linked the suggested minimal PR above. I am not convinced the test in
TestFilterIndexInput.testOverrides is correct. The problem with delegation
pattern ("FilterXyz" classes) is th
dweiss commented on issue #13820:
URL: https://github.com/apache/lucene/issues/13820#issuecomment-2373976921
The test added as part of #11868 is checking whether only abstract methods
are overridden in filter classes. It's a different case here.
--
This is an automated message from the Ap
dweiss commented on issue #13820:
URL: https://github.com/apache/lucene/issues/13820#issuecomment-2373937582
There is FilterIndexInput which extends IndexInput (extends DataInput).
Interesting this hasn't been caught.
--
This is an automated message from the Apache Git Service.
To respond
mikemccand commented on issue #13820:
URL: https://github.com/apache/lucene/issues/13820#issuecomment-2373932348
+1 for API symmetry.
I thought we had reflection based unit tests to validate that our delegating
`FilterXX` classes delegate all methods? Maybe we don't have a
`FilterDa
dweiss opened a new issue, #13820:
URL: https://github.com/apache/lucene/issues/13820
### Description
The change in #12841 brought this pair of methods to DataInput:
```
public final void readGroupVInts(long[] dst, int limit) throws IOException {
... }
protected void readGrou
