navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2133915854
> At moment there's also missing the getter for list of names.
@uschindler, when raising the PR I saw this and thought is it needed or not.
To ensure the scope of the PR was
uschindler commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2133868504
see #13428
This also fixed the concern in other PR with SPI named similarity functions
--
This is an automated message from the Apache Git Service.
To respond to the mes
uschindler closed issue #13393: Add support for reloading the SPI for
KnnVectorsFormat class
URL: https://github.com/apache/lucene/issues/13393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
uschindler commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2133837367
Thanks for bringing this up.
Unfortunately we have no way to automatically enforce this for our NamedSPI
provides (as it is static methods), but we should keep all of them
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2131437707
@benwtrent , @ChrisHegarty as we are not inclined that this is a valid
usecase, can you guys please review the PR
https://github.com/apache/lucene/pull/13394
--
This i
ChrisHegarty commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2130254715
Thanks for the explanation - sounds like a reasonable idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2130144565
> Thanks for the clarification @navneet1v I didn't know folks were
dynamically loading jars for different vector formats.
>
> The idea sounds good to me. I haven't reviewed
benwtrent commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2130105488
Thanks for the clarification @navneet1v I didn't know folks were
dynamically loading jars for different vector formats.
The idea sounds good to me. I haven't reviewed the P
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2130099034
> These other formats are dynamically pluggable, and this change is just
making `KnnVectorsFormat` consistent with them, right?
Yes that is correct.
--
This is an automa
msfroh commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2130092260
Is it fair to say that this change just brings `KnnVectorsFormat` in line
with:
1. PostingsFormat:
https://github.com/apache/lucene/blob/2d6ad2fee6dfd96388594f4de9b37c037efe80
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2129970534
@ChrisHegarty
> The dynamic addition of formats from other class loaders seems reasonable,
though I don't have a use case for it myself. Maybe I'm missing something
ChrisHegarty commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2129931655
The dynamic addition of formats from other class loaders seems reasonable,
though I don't have a use case for it myself. Maybe I'm missing something but
before adding a new AP
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2129870019
That correct if the classes are in the main application it will work.
but in my case during runtime I need to load some other jars(consider them
as plugin) which has the KNN
benwtrent commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2129653735
I still don't understand.
If the SPIs are there, it should work. If the SPI extension didn't work,
none of the current formats would work either as they all rely on it.
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2128519709
> My only concern is why is this necessary?
>
> Is feature parity the only reason?
Currently in my application I want to extend the KNNVectorsFormat just like
Codec,
benwtrent commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2128332920
My only concern is why is this necessary?
Is feature parity the only reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2121465417
I have raised a PR for the fix: https://github.com/apache/lucene/pull/13394
--
This is an automated message from the Apache Git Service.
To respond to the message, please
navneet1v opened a new issue, #13393:
URL: https://github.com/apache/lucene/issues/13393
### Description
## Description
Lucene uses SPI to get the instance for various classes like Codec,
KNNVectorsFormat etc.
Currently Codec class provide a way to reload the SPIs by provid
18 matches
Mail list logo
