dweiss commented on code in PR #14862:
URL: https://github.com/apache/lucene/pull/14862#discussion_r2173616055
##
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/JavaFolderLayoutPlugin.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
dweiss opened a new pull request, #14862:
URL: https://github.com/apache/lucene/pull/14862
This is a small effort to move some of the trivial plugins to Java code. It
should be faster to compile and apply, no functional changes are expected.
I'll port maybe two or three more, then app
dweiss commented on PR #14861:
URL: https://github.com/apache/lucene/pull/14861#issuecomment-3016344860
This part is a beast - thank you for trying to untangle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jpountz commented on issue #14850:
URL: https://github.com/apache/lucene/issues/14850#issuecomment-3016024402
Reading this issue made me wonder if we could make points indexes better by
indexing them by doc ID, ie. treating doc IDs like any other dimension. Then
there should be a way to not
jpountz commented on PR #14858:
URL: https://github.com/apache/lucene/pull/14858#issuecomment-3016015710
This looks like a safe change to backport to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jpountz commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-3016015224
That would work for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
breskeby commented on PR #14861:
URL: https://github.com/apache/lucene/pull/14861#issuecomment-3015978360
This is totally WIP and I raised the PR early here to give a heads up that
I'm looking in reworking these parts of the build. Will ping again when I have
something worth to share and re
breskeby opened a new pull request, #14861:
URL: https://github.com/apache/lucene/pull/14861
This is a work in progress on reworking licence checks. It aims for:
- extract imperative code into binary plugin
- replace internal state across validation tasks
- fix deprecated usage o
dungba88 opened a new pull request, #14860:
URL: https://github.com/apache/lucene/pull/14860
Backport #14009 to 10.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
benwtrent commented on PR #14858:
URL: https://github.com/apache/lucene/pull/14858#issuecomment-3015219801
@jpountz what do you think if we just backport:
https://github.com/apache/lucene/pull/12146 ?
That handles the issue and greatly simplifies things. I am actually not sure
why it
dungba88 commented on PR #14009:
URL: https://github.com/apache/lucene/pull/14009#issuecomment-3015218846
It should be possible to backport to 10.3. I'll raise a PR. Thanks
@vigyasharma for merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
uschindler commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-3015092221
I would definitely go away from Comparator and use the LessThan interface as
the semantics are a bit different. We could supply a wrapper, but where it is
simple to do (and does not n
vigyasharma merged PR #14777:
URL: https://github.com/apache/lucene/pull/14777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma commented on PR #14009:
URL: https://github.com/apache/lucene/pull/14009#issuecomment-3015079473
@dungba88 – Can this change go in 10.3 instead of waiting for 11.0? I didn't
see anything blocking so I updated the changes entry. But I'm running into some
merge issues while backpo
dweiss commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-3015076555
Ah, ok... Yes, could be, could be. It'll be tricky to optimize for whatever
c2 is going to decide to do. I agree the Comparator abstraction - while very
neat from source code point of vie
vigyasharma closed issue #13564: Add refinement of quantized vector scores with
fp distance calculations
URL: https://github.com/apache/lucene/issues/13564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vigyasharma merged PR #14009:
URL: https://github.com/apache/lucene/pull/14009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
github-actions[bot] commented on PR #14859:
URL: https://github.com/apache/lucene/pull/14859#issuecomment-3015065606
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
jbampton opened a new pull request, #14859:
URL: https://github.com/apache/lucene/pull/14859
Just one typo fixed in many places
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vigyasharma commented on PR #14858:
URL: https://github.com/apache/lucene/pull/14858#issuecomment-3015051045
Sneaky bug! Thanks for fixing @benwtrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vigyasharma commented on PR #14858:
URL: https://github.com/apache/lucene/pull/14858#issuecomment-3015049880
> does `getMaxScore` need fixing as well? I see that it adds
`context.docBase` too.
I suppose this gets handled by the `idx < upper` check [on
L427](https://github.com/apache/
21 matches
Mail list logo
