gf2121 commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2125750621
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -32,31 +34,21 @@
public class TopScoreDocCollector extends TopDocsCollector {
pr
gf2121 commented on PR #14753:
URL: https://github.com/apache/lucene/pull/14753#issuecomment-2938706935
Thanks for contribution! I wonder if we should also implement
`SparsexxxDocValues#DocIdRunEnd` in `Lucene90DocValuesProducer` so that this
can be actually used in queries like `FieldExist
gf2121 commented on code in PR #14751:
URL: https://github.com/apache/lucene/pull/14751#discussion_r2125719311
##
lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java:
##
@@ -81,18 +83,20 @@ private float computeMaxScore(int windowMin, int windowMax)
gf2121 commented on code in PR #14751:
URL: https://github.com/apache/lucene/pull/14751#discussion_r2125717928
##
lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java:
##
@@ -166,11 +174,12 @@ private void scoreWindowScoreFirst(
docAndScoreAccB
github-actions[bot] commented on PR #14753:
URL: https://github.com/apache/lucene/pull/14753#issuecomment-2938629247
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
HUSTERGS opened a new pull request, #14753:
URL: https://github.com/apache/lucene/pull/14753
### Description
This try to implement `IndexedDISI#docIDRunEnd`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
zacksiri commented on issue #14243:
URL: https://github.com/apache/lucene/issues/14243#issuecomment-2938445607
I'm looking forward to this happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jpountz commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2124848870
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -32,31 +34,21 @@
public class TopScoreDocCollector extends TopDocsCollector {
p
jpountz commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2124821293
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -32,31 +34,21 @@
public class TopScoreDocCollector extends TopDocsCollector {
p
dweiss commented on issue #14687:
URL: https://github.com/apache/lucene/issues/14687#issuecomment-2936093200
For PRs, I'd argue that most of the time it is the person submitting the PR
that should be getting the email - not everyone. I'm not sure what it's like
for other actions but I do ge
jpountz commented on code in PR #14751:
URL: https://github.com/apache/lucene/pull/14751#discussion_r2124651785
##
lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java:
##
@@ -81,18 +83,20 @@ private float computeMaxScore(int windowMin, int windowMax)
dweiss commented on code in PR #14740:
URL: https://github.com/apache/lucene/pull/14740#discussion_r2124317622
##
.editorconfig:
##
@@ -0,0 +1,918 @@
+# EditorConfig: https://editorconfig.org
+# for consistent code style configuration across editors/IDEs
+
+# top-most EditorConf
dweiss commented on code in PR #14740:
URL: https://github.com/apache/lucene/pull/14740#discussion_r2124321568
##
.editorconfig:
##
@@ -0,0 +1,918 @@
+# EditorConfig: https://editorconfig.org
+# for consistent code style configuration across editors/IDEs
+
+# top-most EditorConf
rmuir commented on issue #14687:
URL: https://github.com/apache/lucene/issues/14687#issuecomment-2936104714
Yes I don't want to change the behavior of pull requests. But those nightly
smoke test mails only go to you.
--
This is an automated message from the Apache Git Service.
To respond
lukewilner commented on issue #14687:
URL: https://github.com/apache/lucene/issues/14687#issuecomment-2935600843
When a workflow fails, is it only the committer who’s notified, or does
GitHub’s built‐in system also email everyone watching the repo? It seems like
we don't have a first‐party
dsmiley commented on code in PR #14740:
URL: https://github.com/apache/lucene/pull/14740#discussion_r2123890792
##
.editorconfig:
##
@@ -0,0 +1,918 @@
+# EditorConfig: https://editorconfig.org
+# for consistent code style configuration across editors/IDEs
+
+# top-most EditorCon
thecoop commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2935358256
That's the desired end state, yes. There's still plenty of implementations
to get through before we can make it final.
--
This is an automated message from the Apache Git Service.
To r
dsmiley commented on code in PR #14740:
URL: https://github.com/apache/lucene/pull/14740#discussion_r2123883879
##
.editorconfig:
##
@@ -0,0 +1,918 @@
+# EditorConfig: https://editorconfig.org
+# for consistent code style configuration across editors/IDEs
+
+# top-most EditorCon
uschindler commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2935190508
Basically the lessThan interface should be marked `@FunctionalInterface` and
wherever possible the lessTahn check should be a lambda or method ref.
--
This is an automated message f
stefanvodita commented on PR #14661:
URL: https://github.com/apache/lucene/pull/14661#issuecomment-2935193494
I created the new label and added it to PRs that were using the old label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2935186542
We should really only have one final PQ implementation to make sure most of
the code can be inlined.
--
This is an automated message from the Apache Git Service.
To respond to the m
thecoop commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2935107791
That's a good idea - I'll look at that when I'm moving onto the more complex
implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
dweiss commented on PR #14720:
URL: https://github.com/apache/lucene/pull/14720#issuecomment-2934789718
> Oh, and great javadocs!
Yes, agree 100% - thank you for adding a human-palatable explanation of
what's going on there.
--
This is an automated message from the Apache Git Servi
rmuir commented on code in PR #14740:
URL: https://github.com/apache/lucene/pull/14740#discussion_r2123507009
##
.editorconfig:
##
@@ -0,0 +1,918 @@
+# EditorConfig: https://editorconfig.org
+# for consistent code style configuration across editors/IDEs
+
+# top-most EditorConfi
dweiss commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2934784274
We could also declare a custom interface with just lessThan and then provide
an adapter in usingComparator... this would dodge the need for implementing
full equality checks across the bo
github-actions[bot] commented on PR #14752:
URL: https://github.com/apache/lucene/pull/14752#issuecomment-2934779564
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
dweiss commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-293418
Good point, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #14743:
URL: https://github.com/apache/lucene/pull/14743#issuecomment-2934776193
Superseded by #14752.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] closed pull request #14743: build(deps): bump holidays from
0.71 to 0.73 in /dev-tools/scripts
URL: https://github.com/apache/lucene/pull/14743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] opened a new pull request, #14752:
URL: https://github.com/apache/lucene/pull/14752
Bumps [holidays](https://github.com/vacanza/holidays) from 0.71 to 0.74.
Release notes
Sourced from https://github.com/vacanza/holidays/releases";>holidays's
releases.
v0.74
dependabot[bot] commented on PR #14752:
URL: https://github.com/apache/lucene/pull/14752#issuecomment-2934776042
### Labels
The following labels could not be found: `skip-changelog`. Please create it
before Dependabot can add it to a pull request.
Please fix the above issue
dweiss merged PR #14661:
URL: https://github.com/apache/lucene/pull/14661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss merged PR #14742:
URL: https://github.com/apache/lucene/pull/14742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss commented on PR #14742:
URL: https://github.com/apache/lucene/pull/14742#issuecomment-2934764099
I think this is ok, although some of these flags are derived from the main
randomization seed so - in theory - they should be identical if your seed is
the same.
--
This is an automate
thecoop commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2934755580
This is only the first pass, covering single-line comparators. There are
several non-trivial implementations that will require more detailed refactoring
(if that is indeed desirable) - u
dweiss commented on code in PR #14740:
URL: https://github.com/apache/lucene/pull/14740#discussion_r2123497566
##
.editorconfig:
##
@@ -0,0 +1,918 @@
+# EditorConfig: https://editorconfig.org
+# for consistent code style configuration across editors/IDEs
+
+# top-most EditorConf
github-actions[bot] commented on PR #14705:
URL: https://github.com/apache/lucene/pull/14705#issuecomment-2934326983
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
github-actions[bot] commented on PR #14751:
URL: https://github.com/apache/lucene/pull/14751#issuecomment-2934315106
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
github-actions[bot] commented on PR #14751:
URL: https://github.com/apache/lucene/pull/14751#issuecomment-2934312990
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
gf2121 opened a new pull request, #14751:
URL: https://github.com/apache/lucene/pull/14751
This tries to speed up `BlockMaxConjunctionBulkScorer` by:
* Score with a default window when lead clause does not have specialized
`shallowAdvance`.
* Stop doc first once dynamic pruning kic
jpountz merged PR #14750:
URL: https://github.com/apache/lucene/pull/14750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
41 matches
Mail list logo
