Re: [PR] Fix TestBooleanMinShouldMatch#testRandomQueries failure. [lucene]

2025-05-30 Thread via GitHub
jpountz merged PR #14715: URL: https://github.com/apache/lucene/pull/14715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Speed up findNextGEQ by aggresive stepping [lucene]

2025-05-30 Thread via GitHub
jpountz commented on PR #14735: URL: https://github.com/apache/lucene/pull/14735#issuecomment-2924481149 Thank you for looking into this, I remember trying this sort of things out but results were a bit mixed. Your idea of doing a single block at first before moving to more aggressive stepp

Re: [PR] Fix resource leak in loadMainDataFromFile [lucene]

2025-05-30 Thread via GitHub
jpountz merged PR #14727: URL: https://github.com/apache/lucene/pull/14727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Refactor main top-n bulk scorers to evaluate hits in a more term-at-a-time fashion. [lucene]

2025-05-30 Thread via GitHub
jpountz commented on PR #14701: URL: https://github.com/apache/lucene/pull/14701#issuecomment-2924451484 Nightly benchmarks saw a good speedup for some queries (`OrHighMed`, `AndHighHigh`, ...) but the slowdown on filtered queries was higher than what I was observing locally: https://bench

Re: [PR] Leverage sorted dim when visiting BKD leaf. [lucene]

2025-05-30 Thread via GitHub
github-actions[bot] commented on PR #12528: URL: https://github.com/apache/lucene/pull/12528#issuecomment-2923786179 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Make task executor non-final [lucene]

2025-05-30 Thread via GitHub
HUSTERGS commented on PR #14524: URL: https://github.com/apache/lucene/pull/14524#issuecomment-2923052803 > @javanna Hey! I kinda disagree with: `general idea was to make concurrency as transparent as possible` since the caller thread is used alongside another exec service. I think trading

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-05-30 Thread via GitHub
benwtrent commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2116185558 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -42,7 +78,35 @@ public VectorScorer getScorer(LeafReaderContext ctx) th

Re: [PR] Support for Re-Ranking Queries using Late Interaction Model Multi-Vectors. [lucene]

2025-05-30 Thread via GitHub
romseygeek commented on PR #14729: URL: https://github.com/apache/lucene/pull/14729#issuecomment-2922773555 > Typical envisioned use-case is to do the full corpus search using ANN search on single-valued vectors, followed by a second pass that reranks results using late-interaction multi-ve

Re: [PR] Speed up findNextGEQ by aggresive stepping [lucene]

2025-05-30 Thread via GitHub
github-actions[bot] commented on PR #14735: URL: https://github.com/apache/lucene/pull/14735#issuecomment-2922768134 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Speed up findNextGEQ by aggresive stepping [lucene]

2025-05-30 Thread via GitHub
HUSTERGS commented on PR #14735: URL: https://github.com/apache/lucene/pull/14735#issuecomment-2922761475 I added a single block pre-check, so if the target locate at the first block, we will not pay the double cost. This change seems quite useful, because it reduces the cost of common case

Re: [PR] Speed up findNextGEQ by aggresive stepping [lucene]

2025-05-30 Thread via GitHub
github-actions[bot] commented on PR #14735: URL: https://github.com/apache/lucene/pull/14735#issuecomment-2922741719 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Clean up query node classes [lucene]

2025-05-30 Thread via GitHub
stefanvodita opened a new pull request, #14737: URL: https://github.com/apache/lucene/pull/14737 I was looking at these classes recently because of #14697 and I saw they hadn't received much attention since 2009. I mostly removed redundant code and comments. -- This is an automated m

Re: [PR] Fix java doc in IndexWriter. [lucene]

2025-05-30 Thread via GitHub
stefanvodita commented on code in PR #14733: URL: https://github.com/apache/lucene/pull/14733#discussion_r2116035019 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -469,9 +469,9 @@ public void onTicketBacklog() { * session can be quickly made availab

Re: [PR] Fix IndexSortSortedNumericDocValuesRangeQuery for int sort (#14732) [lucene]

2025-05-30 Thread via GitHub
mayya-sharipova merged PR #14736: URL: https://github.com/apache/lucene/pull/14736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[PR] Fix IndexSortSortedNumericDocValuesRangeQuery for int sort (#14732) [lucene]

2025-05-30 Thread via GitHub
mayya-sharipova opened a new pull request, #14736: URL: https://github.com/apache/lucene/pull/14736 This query assumed that missing value is always of type long. This modifies it to allow type int as well. The test is added that fails without this change. Backport for #14732 -

Re: [PR] Fix IndexSortSortedNumericDocValuesRangeQuery for int sort [lucene]

2025-05-30 Thread via GitHub
mayya-sharipova merged PR #14732: URL: https://github.com/apache/lucene/pull/14732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

Re: [PR] Speed up findNextGEQ by aggresive stepping [lucene]

2025-05-30 Thread via GitHub
github-actions[bot] commented on PR #14735: URL: https://github.com/apache/lucene/pull/14735#issuecomment-2922136905 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Speed up findNextGEQ by aggresive stepping [lucene]

2025-05-30 Thread via GitHub
HUSTERGS opened a new pull request, #14735: URL: https://github.com/apache/lucene/pull/14735 ### Description This PR propose to increase the step size of `findNextGEQ` to speed up adanving within a block, instead of force using AVX512, this implementation check two IntVector when target

Re: [PR] Grammar and typo fixes [lucene]

2025-05-30 Thread via GitHub
jainankitk merged PR #14734: URL: https://github.com/apache/lucene/pull/14734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Grammar and typo fixes [lucene]

2025-05-30 Thread via GitHub
github-actions[bot] commented on PR #14734: URL: https://github.com/apache/lucene/pull/14734#issuecomment-2921481231 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Grammar and typo fixes [lucene]

2025-05-30 Thread via GitHub
viliam-durina opened a new pull request, #14734: URL: https://github.com/apache/lucene/pull/14734 A collection of grammar issues and typo fixes collected over time studying Lucene sources. No code changed, all changes are documentation. One change is not a simple error: at `IndexWrit