Re: [I] Support for DocIdSetBuilder with (min,max) docId [lucene]

2025-05-19 Thread via GitHub
javanna commented on issue #14485: URL: https://github.com/apache/lucene/issues/14485#issuecomment-2892159524 Hey @jainankitk , I tried a few attempts, but did not get very far. I was not able to put in enough time to put a proposal together and submit a PR yet. I am happy to review changes

[I] action failures sent to bui...@lucene.apache.org [lucene]

2025-05-19 Thread via GitHub
rmuir opened a new issue, #14687: URL: https://github.com/apache/lucene/issues/14687 ### Description Some actions that run against `main`, e.g. on every push, nightly release smoketest and other maintenance tasks. It would be nice if failures were sent to `builds@` mailing list.

Re: [PR] Added toString() method to BytesRefBuilder [lucene]

2025-05-19 Thread via GitHub
msfroh merged PR #14676: URL: https://github.com/apache/lucene/pull/14676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [I] Backward compatibility of codec formats in minor releases [lucene]

2025-05-19 Thread via GitHub
rmuir commented on issue #14623: URL: https://github.com/apache/lucene/issues/14623#issuecomment-2891731520 I agree with you, I dont want to slow anything down either. But if we were to look at say, the last 10 file format changes as a sample for analysis... How many of these f

Re: [PR] Specify and test that IOContext is immutable [lucene]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #14686: URL: https://github.com/apache/lucene/pull/14686#issuecomment-2891605156 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Specify and test that IOContext is immutable [lucene]

2025-05-19 Thread via GitHub
ChrisHegarty opened a new pull request, #14686: URL: https://github.com/apache/lucene/pull/14686 Specify and test that IOContext is immutable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Backward compatibility of codec formats in minor releases [lucene]

2025-05-19 Thread via GitHub
ChrisHegarty commented on issue #14623: URL: https://github.com/apache/lucene/issues/14623#issuecomment-2891591535 Overall I would say that the Lucene project benefits a lot from these new formats and the plethora of bug fixes and improvements in minor releases - I do not want to change tha

Re: [I] Backward compatibility of codec formats in minor releases [lucene]

2025-05-19 Thread via GitHub
rmuir commented on issue #14623: URL: https://github.com/apache/lucene/issues/14623#issuecomment-2891433922 I don't know of any software that handles file formats as proposed, I don't think it is the best solution and just adds complexity. Along the same lines of "be careful what we b

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-19 Thread via GitHub
uschindler commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2891445541 Hi, > ``` > beast3:util.nightly[main]$ cat /proc/config.gz | gunzip | grep CONFIG_HZ > # CONFIG_HZ_PERIODIC is not set > # CONFIG_HZ_100 is not set > # CONFIG_HZ

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-19 Thread via GitHub
rmuir commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2891469123 I'm pretty sure it boils down to a compile-time macro. For arch linux on mike's machine with many cores, easiest solution is to switch to `linux-lts` kernel "with configuration

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-19 Thread via GitHub
uschindler commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2891451314 Wah: https://stackoverflow.com/questions/13427608/how-to-change-kernel-timer-frequency -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Don't run changelog verifier on draft PRs [lucene]

2025-05-19 Thread via GitHub
stefanvodita merged PR #14685: URL: https://github.com/apache/lucene/pull/14685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Don't run changelog verifier on draft PRs [lucene]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #14685: URL: https://github.com/apache/lucene/pull/14685#issuecomment-2891436966 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Don't run changelog verifier on draft PRs [lucene]

2025-05-19 Thread via GitHub
stefanvodita opened a new pull request, #14685: URL: https://github.com/apache/lucene/pull/14685 Noticed the bot was commenting on draft PRs, which is probably not helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] TopFieldCollector mistakenly assumes that all leaves share the same index sort [lucene]

2025-05-19 Thread via GitHub
msokolov commented on issue #14399: URL: https://github.com/apache/lucene/issues/14399#issuecomment-2891382202 > Would it make sense to have different collectors for the two cases, one with and one without a cache? -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Backward compatibility of codec formats in minor releases [lucene]

2025-05-19 Thread via GitHub
msokolov commented on issue #14623: URL: https://github.com/apache/lucene/issues/14623#issuecomment-2891377052 If we had a release policy that required format changes to be released in isolation, would that have helped in this case? If we did that, you could at least revert other (non forma

Re: [I] Nightly benchark regression on pre-filtered vector search [lucene]

2025-05-19 Thread via GitHub
mikemccand commented on issue #14671: URL: https://github.com/apache/lucene/issues/14671#issuecomment-2891105182 Oooh the nightly `knnPerfTest.py` benchy also noted a jump in `Visited Node Count (K)` chart: https://benchmarks.mikemccandless.com/knnResults.html#k_total_visited starting 2025

Re: [I] Nightly benchark regression on pre-filtered vector search [lucene]

2025-05-19 Thread via GitHub
msokolov commented on issue #14671: URL: https://github.com/apache/lucene/issues/14671#issuecomment-2890706274 performance seems to have recovered on https://benchmarks.mikemccandless.com/PreFilteredVectorSearch.html but @mikemccand have you reverted this whlle playing around with java vers

Re: [PR] Added toString() method to BytesRefBuilder [lucene]

2025-05-19 Thread via GitHub
shubhamsrkdev commented on code in PR #14676: URL: https://github.com/apache/lucene/pull/14676#discussion_r2095293465 ## lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java: ## @@ -2599,4 +2599,33 @@ public void testPointInSetQuerySkipsNonMatchingSegments() thro