[PR] Impl intoBitset and docIdRunEnd for wrappers [lucene]

2025-05-05 Thread via GitHub
gf2121 opened a new pull request, #14618: URL: https://github.com/apache/lucene/pull/14618 Impl intoBitset and docIdRunEnd for wrappers. I could only think of `SingletonSortedNumericDocValues` and `SingletonSortedSetDocValues` that might be called, for now. -- This is an automated messag

Re: [I] apache jenkins: Failed to save the JUnit test result [lucene]

2025-05-05 Thread via GitHub
dweiss commented on issue #14617: URL: https://github.com/apache/lucene/issues/14617#issuecomment-2853458615 ASF. https://lists.apache.org/list?bui...@lucene.apache.org:lte=1M:%22failed%20to%20save%22 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] apache jenkins: Failed to save the JUnit test result [lucene]

2025-05-05 Thread via GitHub
dweiss commented on issue #14617: URL: https://github.com/apache/lucene/issues/14617#issuecomment-2853443525 I've seen it a few times. It's an odd error. Doesn't show up in build scans, for example, only in emails. The workspace was wiped out when I checked the one above. Just something to

Re: [I] apache jenkins: Failed to save the JUnit test result [lucene]

2025-05-05 Thread via GitHub
uschindler commented on issue #14617: URL: https://github.com/apache/lucene/issues/14617#issuecomment-2853433638 Does this happen on all builds? To me it looks like it serializes some stdout/stderr and one of the chars is not on the XML whitelist. Unfortunately it does not say which f

[I] apache jenkins: Failed to save the JUnit test result [lucene]

2025-05-05 Thread via GitHub
dweiss opened a new issue, #14617: URL: https://github.com/apache/lucene/issues/14617 ### Description Just noticed this in run reports. If anybody wishes to dig what this may be - feel free to. ``` FATAL: Failed to save the JUnit test result java.io.IOException: java.lang

Re: [PR] Reduce NeighborArray heap memory [lucene]

2025-05-05 Thread via GitHub
weizijun commented on PR #14527: URL: https://github.com/apache/lucene/pull/14527#issuecomment-2853389550 hi, @benwtrent, I updated the ramBytesUsed method, the memory is correct now. > Please also adjust the inner arrays to enforce their maximal length. This way we never over-allocat

[PR] Fix FuzzySet#createSetBasedOnMaxMemory to honor bytes not bits [lucene]

2025-05-05 Thread via GitHub
gsmiller opened a new pull request, #14616: URL: https://github.com/apache/lucene/pull/14616 ### Description Looks like a bug to me, but no unit tests for this (should probably create some). I'm also wondering if we can find a better way to avoid needing this method altogether. It's

Re: [PR] speed up numDeletesToMerge of SoftDeletesRetentionMergePolicy [lucene]

2025-05-05 Thread via GitHub
github-actions[bot] commented on PR #14531: URL: https://github.com/apache/lucene/pull/14531#issuecomment-2852827624 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix FuzzySet#getEstimatedNumberUniqueValuesAllowingForCollisions to account for hashCount [lucene]

2025-05-05 Thread via GitHub
gsmiller commented on PR #14614: URL: https://github.com/apache/lucene/pull/14614#issuecomment-2852817547 Related: also opened #14615 to dry up the public API a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Shrink FuzzySet public API surface area [lucene]

2025-05-05 Thread via GitHub
gsmiller opened a new pull request, #14615: URL: https://github.com/apache/lucene/pull/14615 ### Description Proposal to remove some public APIs we don't use internally anymore and likely don't want to maintain for public consumption. (Would back port with deprecation notices if the

[PR] Fix FuzzySet#getEstimatedNumberUniqueValuesAllowingForCollisions to account for hashCount [lucene]

2025-05-05 Thread via GitHub
gsmiller opened a new pull request, #14614: URL: https://github.com/apache/lucene/pull/14614 ### Description Estimating bloom filter cardinality should account for the number of hash functions used. It appears this method assumes one function is used, which isn't correct. Note

Re: [PR] Overrides rewrite in PointRangeQuery to optimize AllDocs/NoDocs cases [lucene]

2025-05-05 Thread via GitHub
jpountz commented on code in PR #14609: URL: https://github.com/apache/lucene/pull/14609#discussion_r2074166256 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -45,8 +49,8 @@ * For a single-dimensional field this query is a simple range query; in a

Re: [I] Enable jenkins jobs on s390x [lucene]

2025-05-05 Thread via GitHub
dweiss closed issue #14612: Enable jenkins jobs on s390x URL: https://github.com/apache/lucene/issues/14612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Overrides rewrite in PointRangeQuery to optimize AllDocs/NoDocs cases [lucene]

2025-05-05 Thread via GitHub
jpountz commented on PR #14609: URL: https://github.com/apache/lucene/pull/14609#issuecomment-2852297311 +1 to do this Feel free to ask me for a review on a PR if you'd live to give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Add parameters for HNSW codec in Lucene93Codec [LUCENE-10612] [lucene]

2025-05-05 Thread via GitHub
msokolov closed issue #11648: Add parameters for HNSW codec in Lucene93Codec [LUCENE-10612] URL: https://github.com/apache/lucene/issues/11648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-05-05 Thread via GitHub
msokolov merged PR #14226: URL: https://github.com/apache/lucene/pull/14226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-05-05 Thread via GitHub
msokolov commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2851863611 I did another round of testing with luceneutil over a couple different vector datasets and it is consistently outperforming the baseline. Given that and @benwtrent's recent results, I t

Re: [I] Monitor TermFilteredPresearcher does not return stored query if it contains filter field [lucene]

2025-05-05 Thread via GitHub
bjacobowitz commented on issue #14427: URL: https://github.com/apache/lucene/issues/14427#issuecomment-2851859048 On further reflection / investigation, I think updating the documentation is the way to go here. I tried out permitting the filter fields on both sides of the presearcher

Re: [PR] Rewrite APIJAR extractor to use Java 24 classfile API and kill ASM dependency also for build system [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14613: URL: https://github.com/apache/lucene/pull/14613#issuecomment-2851836181 I added an additional check missing previously as replacement for the last line in above output: All referenced classes left over after processing need to be publicly available in `ja

Re: [PR] Rewrite APIJAR extractor to use Java 24 classfile API and kill ASM dependency also for build system [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14613: URL: https://github.com/apache/lucene/pull/14613#issuecomment-2851528596 Output of regnerate is same as before: ``` > Task :lucene:core:generateJdkApiJar24 Loading and analyzing 200 class files... Writing 28 visible classes... Writing stub

Re: [PR] Rewrite APIJAR extractor to use Java 24 classfile API and kill ASM dependency also for build system [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14613: URL: https://github.com/apache/lucene/pull/14613#issuecomment-2851483409 P.S.: The preview flag removal code is not used by verctor API, but I ported it over, too. I tested it with temporrily extracting the Java 24 `ScopedValue` preview code. -- This is

Re: [PR] Introduce a mapping to map sparse labels to a continuous range [lucene]

2025-05-05 Thread via GitHub
mikemccand commented on code in PR #14494: URL: https://github.com/apache/lucene/pull/14494#discussion_r2073325953 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieBuilder.java: ## @@ -201,17 +208,53 @@ void save(DataOutput meta, IndexOutput index) throws

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2850822105 You know what I am doing? --> stay tuned, almost working! > There is a small problem in windows with whitespace in path (missing escapes): > > ``` > C:\Users\Uwe Schin

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2850818605 > As a (former) windows user... Uwe, you're asking for trouble if you have a whitespace in your home dir... I'll take a look. That's why I am doing this! -- This is an automa

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2850815096 Works, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[I] Enable jenkins jobs on s390x [lucene]

2025-05-05 Thread via GitHub
dweiss opened a new issue, #14612: URL: https://github.com/apache/lucene/issues/14612 ### Description These are disabled temporarily (s390x), waiting for JDK24 to be installed. https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-main%20(s390x%20big%20endian)/ https://c

Re: [I] Revert jenkins to use lucene label instead of sticky lucene-solr-1 [lucene]

2025-05-05 Thread via GitHub
dweiss closed issue #14590: Revert jenkins to use lucene label instead of sticky lucene-solr-1 URL: https://github.com/apache/lucene/issues/14590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-05 Thread via GitHub
dweiss commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2850782076 Should work now, @uschindler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Apache jenkins nodes use java 24-ea [lucene]

2025-05-05 Thread via GitHub
dweiss closed issue #14600: Apache jenkins nodes use java 24-ea URL: https://github.com/apache/lucene/issues/14600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-05 Thread via GitHub
mikemccand commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2850707274 This also delayed nightly benchy a couple days ... thanks for fixing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-05 Thread via GitHub
uschindler commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2850594030 There is a small problem in windows with whitespace in path (missing escapes): ``` C:\Users\Uwe Schindler\Projects\lucene\lucene>gradlew :lucene:core:generateJdkApiJar24

[I] TestTermInSetQuery.testDuel occasionally OOMs [lucene]

2025-05-05 Thread via GitHub
dweiss opened a new issue, #14611: URL: https://github.com/apache/lucene/issues/14611 ### Description I believe this is caused by g1gc not able to keep up with garbage generated in this test. Here is an example analysis from a heap dump from a test run on policeman jenkins: !

Re: [PR] Update created version major [lucene]

2025-05-05 Thread via GitHub
rmuir commented on PR #14607: URL: https://github.com/apache/lucene/pull/14607#issuecomment-2850252830 Because that's not what this variable means. If you want to change index backwards compatibility policy, lying about the version is not the way. -1 -- This is an automated message from t

Re: [I] Relax Lucene Index Upgrade Policy to Allow Safe Upgrades Across Multiple Major Versions [lucene]

2025-05-05 Thread via GitHub
vigyasharma commented on issue #13797: URL: https://github.com/apache/lucene/issues/13797#issuecomment-2850118949 This is an interesting proposal, and I like the idea of making version upgrades more streamlined. However, I'm a bit confused with how the proposed mechanism should play out. Co