Re: [I] TopFieldCollector mistakenly assumes that all leaves share the same index sort [lucene]

2025-04-13 Thread via GitHub
jainankitk commented on issue #14399: URL: https://github.com/apache/lucene/issues/14399#issuecomment-2800571535 This is an interesting issue, and as such I don't see any good solution, other than removing the cache itself. I am wondering if it is good idea for Collector to know the `List`,

Re: [PR] Refactor doc values to expose a `DocIdSetIterator` instead of extending `DocIdSetIterator`. [lucene]

2025-04-13 Thread via GitHub
gf2121 commented on PR #14475: URL: https://github.com/apache/lucene/pull/14475#issuecomment-2800544295 > The benefit of adding advanceExact directly to DocIdSetIterator is that then we no longer need to duplicate (and increase polymorphism) impls such as the one returned by DocIdSetIterato

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-13 Thread via GitHub
jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2800331295 After giving some more thought, added new interface `QueryLeafProfilerAggregator`, implementation of which allows aggregating leaf level breakdowns using `THREAD`, `SLICE` or `LEAF` l