Re: [PR] Add AbstractKnnVectorQuery.seed for seeded HNSW [lucene]

2024-12-19 Thread via GitHub
seanmacavaney commented on PR #13635: URL: https://github.com/apache/lucene/pull/13635#issuecomment-2556076932 Hey @benwtrent -- it's been on my todo list to get back to this, but I've gotten bogged down with a bunch of other stuff. If you're willing, please do go ahead and refactor :

[PR] Tighten up initialization of DisjunctionDISIApproximation [lucene]

2024-12-19 Thread via GitHub
gsmiller opened a new pull request, #14082: URL: https://github.com/apache/lucene/pull/14082 1. Add all leads to heap at once via heapfiy operation 2. Very minor tweaks to cost computation loops (avoid multiple iterations) Checked benchmarks and nothing showed up (as expected). I st

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
gsmiller commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1893073059 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
gsmiller commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1893061461 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
gsmiller commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1892988895 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Use the new `loadIntoBitSet` API to speed up dense conjunctions. [lucene]

2024-12-19 Thread via GitHub
msokolov commented on PR #14080: URL: https://github.com/apache/lucene/pull/14080#issuecomment-2555130836 This is great! It makes me wonder if I should try reviving a dense posting encoding I had played around with a while ago where very-high-frequency terms would be encoded in the index us

Re: [PR] Binary vector format for flat and hnsw vectors [lucene]

2024-12-19 Thread via GitHub
benwtrent commented on PR #14078: URL: https://github.com/apache/lucene/pull/14078#issuecomment-2555050252 @gaoj0017 Thank you for your feedback! Truly, y'all inspired us on improving scalar quantization. RaBitQ showed that it is possible to achieve 32x reduction while achieving high

Re: [PR] Add AbstractKnnVectorQuery.seed for seeded HNSW [lucene]

2024-12-19 Thread via GitHub
benwtrent commented on PR #13635: URL: https://github.com/apache/lucene/pull/13635#issuecomment-2554686592 @seanmacavaney do you still want this contributed to Apache Lucene? Its excellent work and I don't want it dying on the vine. If its ok with you, I plan on refactoring it (with a

Re: [PR] Use the new `loadIntoBitSet` API to speed up dense conjunctions. [lucene]

2024-12-19 Thread via GitHub
jpountz merged PR #14080: URL: https://github.com/apache/lucene/pull/14080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
mkhludnev commented on PR #13974: URL: https://github.com/apache/lucene/pull/13974#issuecomment-2553941620 @gsmiller thanks for reviewing. Looking into! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
mkhludnev commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1891648727 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
mkhludnev commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1891551211 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
mkhludnev commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1891524385 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
mkhludnev commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1891510978 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-19 Thread via GitHub
mkhludnev commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1891306672 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (A