Re: [PR] [KNN] Add comment and remove duplicate code [lucene]

dungba88 commented on PR #13594: URL: https://github.com/apache/lucene/pull/13594#issuecomment-2543393217 @benwtrent sorry for the delay. I have addressed the comments. Can you please take a look? Thank you -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss closed issue #14066: Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) URL: https://github.com/apache/lucene/issues/14066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543318314 Oh, you're fast. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543317993 Damn. I'll do it, no problem. Sorry for the noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

rmuir commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543317724 no need for a hassle, thanks for fixing it. I will take care of the tidy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543314867 Thanks. If I read David Delabassee's e-mail correctly, JDK 24 effectively removes it internally. I've committed a quick patch to QuickPatchThreadsFilter to ignore those daemon

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

rmuir commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543313423 thanks for debugging this: good find, since security manager won't be around forever... -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543312691 This only happens with coverage tests. There is a difference in how these are started - they run without the security manager. Turns out ForkJoinPool's default factory has different

Re: [I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss commented on issue #14066: URL: https://github.com/apache/lucene/issues/14066#issuecomment-2543204101 Hmm... Interesting that I can't reproduce this locally. Also, ForkJoinWorkerThread should be demon threads, which are ignored by the default set of filters... Headscratch. -- This

[I] Threads leaking from ForkJoinPool.commonPool (randomization in RandomCodec) [lucene]

dweiss opened a new issue, #14066: URL: https://github.com/apache/lucene/issues/14066 ### Description #14049 added randomization of codec params but as part of that it may spin up new threads when ForkJoinPool.commonPool is started. We have no control over these threads but they do c