Re: [PR] Re-enabling test muted in #11787 [lucene]

2024-12-12 Thread via GitHub
benwtrent merged PR #14061: URL: https://github.com/apache/lucene/pull/14061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [I] TestKnnFloatVectorQuery.testScoreNegativeDotProduct failing seed [lucene]

2024-12-12 Thread via GitHub
benwtrent closed issue #14051: TestKnnFloatVectorQuery.testScoreNegativeDotProduct failing seed URL: https://github.com/apache/lucene/issues/14051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Adjust test for new random quantization formats [lucene]

2024-12-12 Thread via GitHub
benwtrent merged PR #14058: URL: https://github.com/apache/lucene/pull/14058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [I] Support for criteria based DWPT selection inside DocumentWriter [lucene]

2024-12-12 Thread via GitHub
RS146BIJAY commented on issue #13387: URL: https://github.com/apache/lucene/issues/13387#issuecomment-2539436869 @vigyasharma @jpountz @mikemccand Any thoughts on the above approach on using multiple IndexWriter for different group (tenenat) with a read only combined view? -- This is an

Re: [PR] Adjust test for new random quantization formats [lucene]

2024-12-12 Thread via GitHub
msokolov commented on PR #14058: URL: https://github.com/apache/lucene/pull/14058#issuecomment-2539387026 oh I see; I think in other cases like this, I disabled the randomness, but easing the constraint seems OK too. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Adjust test for new random quantization formats [lucene]

2024-12-12 Thread via GitHub
benwtrent commented on PR #14058: URL: https://github.com/apache/lucene/pull/14058#issuecomment-2539364258 @msokolov FYI the test failed because the score was `0.5` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] Re-enabling test muted in #11787 [lucene]

2024-12-12 Thread via GitHub
benwtrent opened a new pull request, #14061: URL: https://github.com/apache/lucene/pull/14061 this test has been muted for a long time. Seems like it has been fixed in the time being. I tried with the same seed & many thousands of runs and it hasn't been a repeat offender. -- This is an

Re: [PR] Add github on-commit tests on MacOS and Windows [lucene]

2024-12-12 Thread via GitHub
dweiss commented on PR #14054: URL: https://github.com/apache/lucene/pull/14054#issuecomment-2539166827 I think distribution tests (run-checks-mod-distribution.tests.yml) run on MacOSX. Also, Uwe has his own jenkins box, which runs Windows and Mac tests (on a virtual machine). These github

Re: [I] Add 9.12.1 Index version constant and backward compat tests [lucene]

2024-12-12 Thread via GitHub
ChrisHegarty commented on issue #14060: URL: https://github.com/apache/lucene/issues/14060#issuecomment-2539153425 https://github.com/apache/lucene/commit/532ef3648dd7020f4c2f36ca1d362822f71e9cfd -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Adjust test for new random quantization formats [lucene]

2024-12-12 Thread via GitHub
msokolov commented on PR #14058: URL: https://github.com/apache/lucene/pull/14058#issuecomment-2539139518 I meant previously the test asserted (implicitly) that the value was in [-EPSILON, EPSILON]. You changed it to assert that the value is > 0. I was proposing a more restrictive criterion

Re: [PR] Adjust test for new random quantization formats [lucene]

2024-12-12 Thread via GitHub
benwtrent commented on PR #14058: URL: https://github.com/apache/lucene/pull/14058#issuecomment-2539129207 > do we still also want to assert that it is < EPSILON? In what way? We care that its greater than `0`. Previously it was already asserting that it was "near" zero via `EPISON`,

[I] Add 9.12.1 Index version constant and backward compat tests [lucene]

2024-12-12 Thread via GitHub
ChrisHegarty opened a new issue, #14060: URL: https://github.com/apache/lucene/issues/14060 Add 9.12.1 Index version constant and backward compat tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Benchmark KNN search with ann-benchmarks [LUCENE-9625] [lucene]

2024-12-12 Thread via GitHub
benwtrent closed issue #10665: Benchmark KNN search with ann-benchmarks [LUCENE-9625] URL: https://github.com/apache/lucene/issues/10665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific