Re: [PR] Add new Directory implementation for AWS S3 [lucene]

2024-12-07 Thread via GitHub
github-actions[bot] commented on PR #13949: URL: https://github.com/apache/lucene/pull/13949#issuecomment-2525356998 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]

2024-12-07 Thread via GitHub
msokolov commented on PR #14049: URL: https://github.com/apache/lucene/pull/14049#issuecomment-2525276990 Thank Simon, that's good feedback about avoiding randomization for these tests. There's nothing to revert - this hasn't been committed, it's just github running tests that is failing. I

Re: [PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]

2024-12-07 Thread via GitHub
s1monw commented on PR #14049: URL: https://github.com/apache/lucene/pull/14049#issuecomment-2525074361 @msokolov I didn't invent this test. Yet, we never tested the current version obeying with it's own BWC expecations. Please make sure nothing randomizes anything in this test. BWC tests a

Re: [PR] Reduce specialization in `ForUtil` and `ForDeltaUtil`. [lucene]

2024-12-07 Thread via GitHub
jpountz merged PR #14048: URL: https://github.com/apache/lucene/pull/14048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa