Re: [PR] SortedSet DV Multi Range query [lucene]

2024-12-06 Thread via GitHub
github-actions[bot] commented on PR #13974: URL: https://github.com/apache/lucene/pull/13974#issuecomment-2524694965 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]

2024-12-06 Thread via GitHub
msokolov commented on PR #14049: URL: https://github.com/apache/lucene/pull/14049#issuecomment-2524594249 Another test fails now (this is going to be fun, it's hard to ferret all these things out proactively): ``` TestBasicBackwardsCompatibility > testIndexOldIndex {Lucene-Version:

Re: [PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]

2024-12-06 Thread via GitHub
msokolov commented on PR #14049: URL: https://github.com/apache/lucene/pull/14049#issuecomment-2523957319 oops a test failed; my bad for only beasting the ones in core ... I'll look at this one: gradlew :lucene:join:test --tests "org.apache.lucene.search.join.TestBlockJoin.testSi

[PR] Randomize KnnVector codec params in RandomCodec; addresses gh-14047 [lucene]

2024-12-06 Thread via GitHub
msokolov opened a new pull request, #14049: URL: https://github.com/apache/lucene/pull/14049 This adds the randomization to RandomCodec and addresses some test issues. * In a few places I had to disable the randomization; basically wherever we are carefully testing scores. In these ca

Re: [I] TestSoftDeletesDirectoryReaderWrapper.testAvoidWrappingReadersWithoutSoftDeletes AssertionError: expected:<5> but was:<3> [lucene]

2024-12-06 Thread via GitHub
easyice commented on issue #14020: URL: https://github.com/apache/lucene/issues/14020#issuecomment-2523524793 It seems related to LUCENE-8484, a fully deleted segments with soft delete (`numDocs() == 0`) will skip wrap the reader in `SoftDeletesDirectoryReaderWrapper#SoftDeletesSubReaderWr

[PR] Reduce specialization in `ForUtil` and `ForDeltaUtil`. [lucene]

2024-12-06 Thread via GitHub
jpountz opened a new pull request, #14048: URL: https://github.com/apache/lucene/pull/14048 These classes specialize all bits per value up to 24. But performance of high numbers of bits per value is not very important, because they are used by short postings lists, which are fast to iterate

Re: [PR] Reduce specialization in `ForUtil` and `ForDeltaUtil`. [lucene]

2024-12-06 Thread via GitHub
jpountz commented on PR #14048: URL: https://github.com/apache/lucene/pull/14048#issuecomment-2523508678 luceneutil doesn't notice any difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] Randomize KNN vector format parameters in tests [lucene]

2024-12-06 Thread via GitHub
msokolov opened a new issue, #14047: URL: https://github.com/apache/lucene/issues/14047 ### Description I discovered while doing some sweeping refactoring changes that we lack coverage of many vector field features, like scalar compression and concurrent merging. We even lack randomi

Re: [I] Improve encoding of HNSW graph offsets [LUCENE-9845] [lucene]

2024-12-06 Thread via GitHub
msokolov commented on issue #10884: URL: https://github.com/apache/lucene/issues/10884#issuecomment-2523407746 Closing because we now have dense/sparse customizations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Add .editorConfig [LUCENE-9563] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #10603: Add .editorConfig [LUCENE-9563] URL: https://github.com/apache/lucene/issues/10603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Add .editorConfig [LUCENE-9563] [lucene]

2024-12-06 Thread via GitHub
msokolov commented on issue #10603: URL: https://github.com/apache/lucene/issues/10603#issuecomment-2523426141 I think we can resolve now that we have automatic tidy-ing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Add TrackingQuery to track matching documents [LUCENE-9640] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #10679: Add TrackingQuery to track matching documents [LUCENE-9640] URL: https://github.com/apache/lucene/issues/10679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] Make 'precommit' an alias for gradle 'check' task. [LUCENE-9658] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #10697: Make 'precommit' an alias for gradle 'check' task. [LUCENE-9658] URL: https://github.com/apache/lucene/issues/10697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Fix looping bug when calculating full KNN results in KnnGraphTester [LUCENE-9798] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #10837: Fix looping bug when calculating full KNN results in KnnGraphTester [LUCENE-9798] URL: https://github.com/apache/lucene/issues/10837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Rename VectorValues#dimension to VectorValues#getNumDimensions? [LUCENE-10177] [lucene]

2024-12-06 Thread via GitHub
msokolov commented on issue #11214: URL: https://github.com/apache/lucene/issues/11214#issuecomment-2523412612 I think we're settled on the current naming at this point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] KnnVectorQuery doesn't tie break by doc ID [LUCENE-10397] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #11433: KnnVectorQuery doesn't tie break by doc ID [LUCENE-10397] URL: https://github.com/apache/lucene/issues/11433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] Rename VectorValues#dimension to VectorValues#getNumDimensions? [LUCENE-10177] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #11214: Rename VectorValues#dimension to VectorValues#getNumDimensions? [LUCENE-10177] URL: https://github.com/apache/lucene/issues/11214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Improve encoding of HNSW graph offsets [LUCENE-9845] [lucene]

2024-12-06 Thread via GitHub
msokolov closed issue #10884: Improve encoding of HNSW graph offsets [LUCENE-9845] URL: https://github.com/apache/lucene/issues/10884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] Refactor dummy scorables. [lucene]

2024-12-06 Thread via GitHub
jpountz opened a new pull request, #14046: URL: https://github.com/apache/lucene/pull/14046 This makes our scorers that produce dummy scorables share the same implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] adding changes for PR #13819 [lucene]

2024-12-06 Thread via GitHub
benwtrent merged PR #14044: URL: https://github.com/apache/lucene/pull/14044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Introduce a BulkScorer for DisjunctionMaxQuery. [lucene]

2024-12-06 Thread via GitHub
jpountz merged PR #14040: URL: https://github.com/apache/lucene/pull/14040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] debug what happened with 14031 [lucene]

2024-12-06 Thread via GitHub
jpountz commented on issue #14042: URL: https://github.com/apache/lucene/issues/14042#issuecomment-2522692498 I have a computer with a `AMD Ryzen 9 3900X 12-Core Processor` in case you want me to run some benchmarks. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Remove unused +1 on doc buffer length. [lucene]

2024-12-06 Thread via GitHub
jpountz merged PR #14043: URL: https://github.com/apache/lucene/pull/14043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Track the number of docs left to decode instead of the number of docs decoded. [lucene]

2024-12-06 Thread via GitHub
jpountz merged PR #14045: URL: https://github.com/apache/lucene/pull/14045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa