Re: [PR] Grammar and typo fixes [lucene]

msokolov commented on code in PR #14019: URL: https://github.com/apache/lucene/pull/14019#discussion_r1864959587 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -101,8 +101,8 @@ * whether a new index is created, or whether an existing index is opened.

Re: [PR] Grammar and typo fixes [lucene]

msokolov commented on code in PR #14019: URL: https://github.com/apache/lucene/pull/14019#discussion_r1864957737 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -184,7 +184,7 @@ List filterAndLock(Predicate /** * Removes the given

Re: [PR] Use Arrays.mismatch in FSTCompiler#add. [lucene]

msokolov merged PR #13924: URL: https://github.com/apache/lucene/pull/13924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Use Arrays.mismatch in FSTCompiler#add. [lucene]

msokolov commented on PR #13924: URL: https://github.com/apache/lucene/pull/13924#issuecomment-2510044787 Thanks, LGTM, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] [Discuss] Reducing allocations in HnswUtil::markRooted [lucene]

msokolov commented on issue #14002: URL: https://github.com/apache/lucene/issues/14002#issuecomment-2509991790 > Should we be concerned about the chance of a humongous allocation (if the stack is really deep) with primitives? If not, I can give it a shot with running the same benchmarks wit

Re: [PR] Fix changelog for GITHUB#14011 [lucene]

msokolov merged PR #14018: URL: https://github.com/apache/lucene/pull/14018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Fix changelog for GITHUB#14011 [lucene]

msokolov commented on PR #14018: URL: https://github.com/apache/lucene/pull/14018#issuecomment-2509978645 @viliam-durina would you also like to attempt the backport of this and the related commit to 10.1? Generally this is a matter of cherry-picking the change on to the branch, in this case

Re: [PR] Better encapsulate locking logic in HnswGraphBuilder [lucene]

msokolov commented on PR #14016: URL: https://github.com/apache/lucene/pull/14016#issuecomment-2509959742 I'm not sure we need this because we guarantee that an index cannot be written while it is being read under normal circumstances, and I think it's actually good to expose less functiona

Re: [PR] Fix changelog for GITHUB#14011 [lucene]

msokolov commented on PR #14018: URL: https://github.com/apache/lucene/pull/14018#issuecomment-2509947234 Thanks for that, I will move to ``Optimizations` section and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Introduces IndexInput#updateReadAdvice to change the ReadAdvice while merging vectors [lucene]

msokolov commented on PR #13985: URL: https://github.com/apache/lucene/pull/13985#issuecomment-2509938326 The impact on search times is surprising, as you said. Can you clarify one thing a about the benchmark setup: does it perform searches concurrently with indexing (and merging) on the sa

Re: [PR] Remove vector values copy() methods, moving IndexInput.clone() and temp storage into lower-level interfaces [lucene]

msokolov closed pull request #13872: Remove vector values copy() methods, moving IndexInput.clone() and temp storage into lower-level interfaces URL: https://github.com/apache/lucene/pull/13872 -- This is an automated message from the Apache Git Service. To respond to the message, please log