Re: [PR] Introduces IndexInput#updateReadAdvice to change the ReadAdvice while merging vectors [lucene]

2024-11-23 Thread via GitHub
uschindler commented on PR #13985: URL: https://github.com/apache/lucene/pull/13985#issuecomment-2495537495 Thanks @ChrisHegarty for taking care. If I have any additional comments about API I will open another followup PR. Still in 🇨🇷, flying back this evening. -- This is an automated

Re: [PR] Add new Directory implementation for AWS S3 [lucene]

2024-11-23 Thread via GitHub
albogdano commented on PR #13949: URL: https://github.com/apache/lucene/pull/13949#issuecomment-2495524936 I refactored the code and got rid of the AWS SDK in favor of the minimal S3 Client [aws-lightweight-client-java](https://github.com/davidmoten/aws-lightweight-client-java). Also,

Re: [PR] Taxonomy counts are incorrect due to ordinal sorting (#14008) [lucene]

2024-11-23 Thread via GitHub
stefanvodita merged PR #14010: URL: https://github.com/apache/lucene/pull/14010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [I] Taxonomy counts are incorrect due to ordinal sorting [lucene]

2024-11-23 Thread via GitHub
stefanvodita closed issue #14008: Taxonomy counts are incorrect due to ordinal sorting URL: https://github.com/apache/lucene/issues/14008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Improve checksum calculations [lucene]

2024-11-23 Thread via GitHub
jfboeuf commented on code in PR #13989: URL: https://github.com/apache/lucene/pull/13989#discussion_r1855164834 ## lucene/core/src/test/org/apache/lucene/store/TestBufferedChecksum.java: ## @@ -63,4 +67,127 @@ public void testRandom() { } assertEquals(c1.getValue(), c2

Re: [PR] Improve checksum calculations [lucene]

2024-11-23 Thread via GitHub
jfboeuf commented on code in PR #13989: URL: https://github.com/apache/lucene/pull/13989#discussion_r1855164624 ## lucene/core/src/test/org/apache/lucene/store/TestBufferedChecksum.java: ## @@ -63,4 +67,127 @@ public void testRandom() { } assertEquals(c1.getValue(), c2