Re: [PR] Tighten up IndexSortSortedNumericDocValuesRangeQuery index sort validation [lucene]

2024-11-15 Thread via GitHub
github-actions[bot] commented on PR #13973: URL: https://github.com/apache/lucene/pull/13973#issuecomment-2480201240 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Make CombinedFieldQuery eligible for WAND/MAXSCORE. [lucene]

2024-11-15 Thread via GitHub
jpountz commented on PR #13999: URL: https://github.com/apache/lucene/pull/13999#issuecomment-248054 Here are luceneutil results on wikibigall after applying https://github.com/mikemccand/luceneutil/pull/318: ``` TaskQPS baseline StdDevQPS my_m

[PR] Make CombinedFieldQuery eligible for WAND/MAXSCORE. [lucene]

2024-11-15 Thread via GitHub
jpountz opened a new pull request, #13999: URL: https://github.com/apache/lucene/pull/13999 `CombinedFieldQuery` currently returns an infinite maximum score. We can do better by returning the maximum score that the sim scorer can return, which in the case of BM25 is bounded by the IDF. This

Re: [PR] Remove duplicate test code [lucene]

2024-11-15 Thread via GitHub
LuXugang merged PR #13982: URL: https://github.com/apache/lucene/pull/13982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Add IndexInput isLoaded [lucene]

2024-11-15 Thread via GitHub
navneet1v commented on PR #13998: URL: https://github.com/apache/lucene/pull/13998#issuecomment-2479683979 @ChrisHegarty this will be a very useful thing. Can we also figure out how much data is loaded with this API? So lets say an IndexInput is 30GB and only 10GB is loaded/mapped in memory

Re: [I] Add refinement of quantized vector scores with fp distance calculations [lucene]

2024-11-15 Thread via GitHub
jmazanec15 commented on issue #13564: URL: https://github.com/apache/lucene/issues/13564#issuecomment-2479340671 > Hi all, I was looking at this idea for some experimentation ideas (not mean to be intrusive to ongoing effort). Hey @dungba88 - not intrusive at all! I ended up not havi

[PR] Add IndexInput isLoaded [lucene]

2024-11-15 Thread via GitHub
ChrisHegarty opened a new pull request, #13998: URL: https://github.com/apache/lucene/pull/13998 This commit adds `IndexInput::isLoaded` to help determine if the contents of an input is resident in physical memory. The intent of this new method is to help build inspection and diagnost

Re: [I] Strange javac "automatic module" warning for `benchmark-jmh` [lucene]

2024-11-15 Thread via GitHub
viswanathk commented on issue #13992: URL: https://github.com/apache/lucene/issues/13992#issuecomment-2478792107 @mikemccand gave it a shot at #13997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Suppressing "automatic module" warning for benchmark-jmh [lucene]

2024-11-15 Thread via GitHub
viswanathk opened a new pull request, #13997: URL: https://github.com/apache/lucene/pull/13997 jmh.core is not modularized resulting in this error. The other modules seem fine though. Probably can be removed once jmh updates the module-info. Closes #13992 -- This is an auto

Re: [PR] PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants (#13845) [lucene]

2024-11-15 Thread via GitHub
cpoerschke merged PR #13891: URL: https://github.com/apache/lucene/pull/13891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Introduces IndexInput#updateReadAdvice to change the ReadAdvice while merging vectors [lucene]

2024-11-15 Thread via GitHub
ChrisHegarty commented on PR #13985: URL: https://github.com/apache/lucene/pull/13985#issuecomment-2478730077 I added some asserts to the asserting wrappers to ensure that finishMerge is always called. I think that the code is in good shape now. Pending some benchmark runs.. @shateja

Re: [PR] [WIP] Multi-Vector support for HNSW search [lucene]

2024-11-15 Thread via GitHub
jimczi commented on PR #13525: URL: https://github.com/apache/lucene/pull/13525#issuecomment-2478490713 > One reason to not add this would be if it makes the single vector setup hard to evolve. I'd like to understand if (and how) this is happening, and think on how we can address those conc

Re: [PR] PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) [lucene]

2024-11-15 Thread via GitHub
cpoerschke commented on code in PR #13891: URL: https://github.com/apache/lucene/pull/13891#discussion_r1843436542 ## lucene/CHANGES.txt: ## @@ -47,6 +52,9 @@ API Changes the entire segment should be scored. Subclasses that override the method should instead override its rep

Re: [PR] PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) [lucene]

2024-11-15 Thread via GitHub
cpoerschke commented on code in PR #13891: URL: https://github.com/apache/lucene/pull/13891#discussion_r1843433531 ## lucene/CHANGES.txt: ## @@ -47,6 +52,9 @@ API Changes the entire segment should be scored. Subclasses that override the method should instead override its rep