Re: [PR] Avoid allocating liveDocs when no soft-deletes [lucene]

2024-10-12 Thread via GitHub
dnhatn commented on code in PR #13895: URL: https://github.com/apache/lucene/pull/13895#discussion_r1797921264 ## lucene/core/src/java/org/apache/lucene/index/PendingSoftDeletes.java: ## @@ -76,15 +76,14 @@ void onNewReader(CodecReader reader, SegmentCommitInfo info) throws IOE

Re: [PR] Avoid allocating liveDocs when no soft-deletes [lucene]

2024-10-12 Thread via GitHub
dnhatn merged PR #13895: URL: https://github.com/apache/lucene/pull/13895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Avoid allocating liveDocs when no soft-deletes [lucene]

2024-10-12 Thread via GitHub
dnhatn commented on PR #13895: URL: https://github.com/apache/lucene/pull/13895#issuecomment-2408776136 Thanks Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Compute multiple float aggregations in one go [lucene]

2024-10-12 Thread via GitHub
github-actions[bot] commented on PR #12547: URL: https://github.com/apache/lucene/pull/12547#issuecomment-2408757737 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] IndexOrDocValuesQuery in query highlighting [lucene]

2024-10-12 Thread via GitHub
prudhvigodithi opened a new pull request, #13902: URL: https://github.com/apache/lucene/pull/13902 ### Description Coming from https://github.com/apache/lucene/issues/12686 does adding one more condition to check for `IndexOrDocValuesQuery` help? Please let me know. Thanks

Re: [I] Relax Lucene Index Upgrade Policy to Allow Safe Upgrades Across Multiple Major Versions [lucene]

2024-10-12 Thread via GitHub
markrmiller commented on issue #13797: URL: https://github.com/apache/lucene/issues/13797#issuecomment-2408708392 Thank you, Adrien, for your thoughtful response and for sharing your expertise on this topic. Your insights are valuable, and I'd like to address a few points and seek some clar

[PR] Dry up EverythingEnum and BlockDocsEnum in Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear opened a new pull request, #13901: URL: https://github.com/apache/lucene/pull/13901 Sam as #13892 but much simpler. Almost exclusively mechanical moving of fields to a shared parent and obvious deduplication. The only exceptions being the introduction of an array summing

Re: [I] Add an S3-based directory. [lucene]

2024-10-12 Thread via GitHub
shubhamvishu commented on issue #13868: URL: https://github.com/apache/lucene/issues/13868#issuecomment-2408668368 Nice idea @jpountz! I'll try spending sometime working on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Create a community metrics dashboard [lucene]

2024-10-12 Thread via GitHub
prudhvigodithi commented on issue #13896: URL: https://github.com/apache/lucene/issues/13896#issuecomment-2408662671 OpenSearch Project has one https://github.com/opensearch-project/opensearch-metrics and I'm one of the maintainer for this metrics project. Happy to drive this here and be pa

Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]

2024-10-12 Thread via GitHub
prudhvigodithi commented on issue #13898: URL: https://github.com/apache/lucene/issues/13898#issuecomment-2408659537 Here is the sample PR with change-log verifier action added https://github.com/prudhvigodithi/lucene/pull/1, we can add the same workflow to lucene repo. But I see the error

Re: [PR] Changelog verifier sample PR [lucene]

2024-10-12 Thread via GitHub
prudhvigodithi closed pull request #13900: Changelog verifier sample PR URL: https://github.com/apache/lucene/pull/13900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] Changelog verifier sample PR [lucene]

2024-10-12 Thread via GitHub
prudhvigodithi opened a new pull request, #13900: URL: https://github.com/apache/lucene/pull/13900 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on PR #13892: URL: https://github.com/apache/lucene/pull/13892#issuecomment-2408571620 Thanks Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear merged PR #13892: URL: https://github.com/apache/lucene/pull/13892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
jpountz commented on code in PR #13892: URL: https://github.com/apache/lucene/pull/13892#discussion_r1797694604 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1326,8 +1270,88 @@ public BytesRef getPayload() { } @Overri

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on PR #13892: URL: https://github.com/apache/lucene/pull/13892#issuecomment-2408539235 All addressed Adrien or would you like me to split this up a little? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on code in PR #13892: URL: https://github.com/apache/lucene/pull/13892#discussion_r1797690836 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1203,70 +1175,53 @@ public long cost() { } } - fi

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on code in PR #13892: URL: https://github.com/apache/lucene/pull/13892#discussion_r1797690775 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -36,18 +36,9 @@ import org.apache.lucene.codecs.CodecUtil;

Re: [PR] Lazy initialize ForDeltaUtil and ForUtil in Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear merged PR #13885: URL: https://github.com/apache/lucene/pull/13885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Lazy initialize ForDeltaUtil and ForUtil in Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on PR #13885: URL: https://github.com/apache/lucene/pull/13885#issuecomment-2408517553 Thanks Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on code in PR #13892: URL: https://github.com/apache/lucene/pull/13892#discussion_r1797677131 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1316,8 +1257,88 @@ public BytesRef getPayload() { }

Re: [PR] Dry up both the two ImpactsEnum Implementation ins Lucene912PostingsReader [lucene]

2024-10-12 Thread via GitHub
jpountz commented on code in PR #13892: URL: https://github.com/apache/lucene/pull/13892#discussion_r1797607993 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1203,70 +1175,53 @@ public long cost() { } } - final class B

Re: [PR] Use RandomAccessInput instead of seeking in Lucene90DocValuesProducer [lucene]

2024-10-12 Thread via GitHub
original-brownbear merged PR #13894: URL: https://github.com/apache/lucene/pull/13894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Use RandomAccessInput instead of seeking in Lucene90DocValuesProducer [lucene]

2024-10-12 Thread via GitHub
original-brownbear commented on PR #13894: URL: https://github.com/apache/lucene/pull/13894#issuecomment-2408457832 Thanks Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com