Re: [PR] Have value and count in LabelAndValue only for TaxonomyFacets [lucene]

2024-09-22 Thread via GitHub
mikemccand commented on code in PR #13740: URL: https://github.com/apache/lucene/pull/13740#discussion_r1770557016 ## lucene/facet/src/java/org/apache/lucene/facet/LabelAndValue.java: ## @@ -52,11 +41,81 @@ public boolean equals(Object _other) { return false; }

Re: [PR] Try using Murmurhash 3 for bloom filters [lucene]

2024-09-22 Thread via GitHub
shubhamvishu commented on PR #12868: URL: https://github.com/apache/lucene/pull/12868#issuecomment-2366731604 @jpountz I have addressed your comments now and kept the bit mixing logic simple as proposed initially. Let me know if the change looks good now. Thanks! On the side note, I s