Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1739517732
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -275,6 +286,52 @@ public float matchCost() {
}
}
+ private static c
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1739511676
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -440,6 +498,101 @@ private String formatScoreExplanation(int matches, int
sta
gsmiller commented on code in PR #13702:
URL: https://github.com/apache/lucene/pull/13702#discussion_r1739438582
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java:
##
@@ -58,15 +61,33 @@ class DrillSidewaysQuery extends Query {
*/
DrillSidewaysQuery
epotyom commented on PR #13702:
URL: https://github.com/apache/lucene/pull/13702#issuecomment-2322322618
> 1. Thank you for checking!, 2) It's crazy that we have to check in the
first place for a change like this! I still wish we understood that phantom
regression... :)
So true! I'll
gsmiller commented on PR #13702:
URL: https://github.com/apache/lucene/pull/13702#issuecomment-2322295101
> Benchmark results are ok
1) Thank you for checking!, 2) It's crazy that we have to check in the first
place for a change like this! I still wish we understood that phantom
regr
jpountz commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1739357851
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -275,6 +286,52 @@ public float matchCost() {
}
}
+ private static c
epotyom commented on PR #13702:
URL: https://github.com/apache/lucene/pull/13702#issuecomment-2321969793
Benchmark results are ok:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDevPct diff p-value
BrowseDa
gsmiller commented on PR #13701:
URL: https://github.com/apache/lucene/pull/13701#issuecomment-2321956725
++ thanks for the cleanup. I can't remember what I was thinking when I put
that throws declaration in. I must have had some subclass that needed this
while working on the change but I d
gsmiller commented on issue #13705:
URL: https://github.com/apache/lucene/issues/13705#issuecomment-2321937351
I'll work on this. I've got a half-baked implementation ready to test and am
working on getting some tasks added to luceneutil benchmarks to measure.
--
This is an automated mess
dweiss commented on PR #13700:
URL: https://github.com/apache/lucene/pull/13700#issuecomment-2321425125
> looks good. I will report issues in the seldomy executed tasks (like
regenerate)
This is already sanity checked when you touch/ alter gradle files, along
with other things.
h
uschindler commented on PR #13700:
URL: https://github.com/apache/lucene/pull/13700#issuecomment-2321306220
I also tested `gradlew :lucene:core:regenerate` and `gradlew eclipse`. Both
work and the availability checks of toolkit autodownload works.
--
This is an automated message from the
iverase opened a new pull request, #13704:
URL: https://github.com/apache/lucene/pull/13704
While checking the latitude bounds we are doing the following `lat2 >=
latBase + maxLatDelta` which can overflow. On the other hand when checking the
longitude we are doing `lon2 - lonBase >= maxLonD
ChrisHegarty merged PR #13701:
URL: https://github.com/apache/lucene/pull/13701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
msokolov commented on PR #13683:
URL: https://github.com/apache/lucene/pull/13683#issuecomment-2321082229
I honestly thought it was a mistake, but now I realize the hiding of
getGraph() was intentional! I restored it now. I think this should be OK to
merge?
--
This is an automated messa
epotyom commented on PR #13702:
URL: https://github.com/apache/lucene/pull/13702#issuecomment-2320928495
@javanna , it was never released, so yeah, I should have used "Remove" as a
title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dweiss closed issue #13698: Upgrade to gradle 8.10
URL: https://github.com/apache/lucene/issues/13698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: is
dweiss merged PR #13700:
URL: https://github.com/apache/lucene/pull/13700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss commented on code in PR #13700:
URL: https://github.com/apache/lucene/pull/13700#discussion_r1738394330
##
gradle/documentation/render-javadoc.gradle:
##
@@ -32,7 +32,7 @@ allprojects {
missingdoclet "org.apache.lucene.tools:missing-doclet"
}
-ext {
+
javanna commented on PR #13702:
URL: https://github.com/apache/lucene/pull/13702#issuecomment-2320764765
Has a version of Lucene including CollectorOwner been released yet? I was
hoping that deprecating is not necessary, we could directly remove it perhaps?
--
This is an automated message
epotyom commented on issue #13671:
URL: https://github.com/apache/lucene/issues/13671#issuecomment-2320725824
Draft PR for this issue: https://github.com/apache/lucene/pull/13702 ,
--
@gsmiller ,
> I'd like to see if we could bake this into IndexSearcher.
> ...
iverase opened a new issue, #13703:
URL: https://github.com/apache/lucene/issues/13703
### Description
I found an edge case were given an enough narrow polygon close to latitude,
then it will not match any point even where theoretically the point should
match. The issue is easy to re
vsop-479 commented on PR #13596:
URL: https://github.com/apache/lucene/pull/13596#issuecomment-2320609552
I can't figure out what can we reuse from prior `PostingsEnum`.
If we want reuse prior `PostingsEnum`'s docBuffer( if it still stay in first
block), we should not reset `docBuffe
ChrisHegarty commented on code in PR #13700:
URL: https://github.com/apache/lucene/pull/13700#discussion_r1738264722
##
gradle/documentation/render-javadoc.gradle:
##
@@ -32,7 +32,7 @@ allprojects {
missingdoclet "org.apache.lucene.tools:missing-doclet"
}
-ext
23 matches
Mail list logo
