kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2270443993
Thank you @vigyasharma!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
kaivalnp commented on code in PR #13594:
URL: https://github.com/apache/lucene/pull/13594#discussion_r1704945107
##
lucene/core/src/java/org/apache/lucene/search/KnnQueryUtils.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
vsop-479 commented on code in PR #13596:
URL: https://github.com/apache/lucene/pull/13596#discussion_r1701382048
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java:
##
@@ -97,5 +111,82 @@ public int lookup(BytesRef id) throws IOException {
vigyasharma merged PR #13285:
URL: https://github.com/apache/lucene/pull/13285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1704745053
##
lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java:
##
@@ -475,6 +479,62 @@ public void testApproximate() throws IOException {
benwtrent opened a new pull request, #13633:
URL: https://github.com/apache/lucene/pull/13633
This adds the capability to write and read knn vectors from a memory index.
It currently enforces the lower level codec restriction of only one knn
vector per field and it does not support n
gsmiller commented on code in PR #13631:
URL: https://github.com/apache/lucene/pull/13631#discussion_r1704396687
##
lucene/core/src/java/org/apache/lucene/codecs/lucene912/ForDeltaUtil.java:
##
@@ -41,10 +54,275 @@ private static void prefixSumOfOnes(long[] arr, long base)
{
benwtrent closed issue #13614: int4 doesn't handle `cosine` similarity correctly
URL: https://github.com/apache/lucene/issues/13614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
benwtrent merged PR #13615:
URL: https://github.com/apache/lucene/pull/13615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
gsmiller commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1704183629
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -240,9 +219,38 @@ public ScorerSupplier scorerSupplier(LeafRea
bjacobowitz closed pull request #13109: Add WrappedCandidateMatcher for
composing matchers
URL: https://github.com/apache/lucene/pull/13109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
bjacobowitz commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2269027662
Closing, see PR #13632 with new approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bjacobowitz opened a new pull request, #13632:
URL: https://github.com/apache/lucene/pull/13632
### Description
In `CandidateMatcher`, increase visibility of `matchQuery()` (from
protected), `finish()` and `reportError()` (from package-private) to public, so
that a `CandidateMatcher`
kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2268639204
There was a conflict in `CHANGES.txt` after a recent commit, merged from
`main` and resolved that
@vigyasharma I've tried to address all open comments, please let me know if
somethin
14 matches
Mail list logo