Re: [PR] Compute facets while collecting [lucene]

2024-07-28 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694596250 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

2024-07-28 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694595387 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdToComparable.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] gh-12627: HnswGraphBuilder connects disconnected HNSW graph components [lucene]

2024-07-28 Thread via GitHub
github-actions[bot] commented on PR #13566: URL: https://github.com/apache/lucene/pull/13566#issuecomment-2254726087 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] KnnFloatVectorQuery misses highest-ranking results that FloatVectorSimilarityQuery retrieves [lucene]

2024-07-28 Thread via GitHub
david-sitsky commented on issue #13611: URL: https://github.com/apache/lucene/issues/13611#issuecomment-2254680587 @benwtrent - thank you so much for your insights and recommendation! I will try using m=16 and b=250 by default when we create our indexes to see if this improves things overa