donnerpeter commented on code in PR #13612:
URL: https://github.com/apache/lucene/pull/13612#discussion_r1694008710
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Suggester.java:
##
@@ -71,16 +76,26 @@ private Suggester(
* entries are stored as fast-t
donnerpeter merged PR #13612:
URL: https://github.com/apache/lucene/pull/13612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1694003960
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdinalGetter.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
benwtrent opened a new issue, #13616:
URL: https://github.com/apache/lucene/issues/13616
### Description
We should have a nightly test that verifies expected recall for different
vector spaces.
While in the past we have leaned on lucene nightly benchmarks to detect
different
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1693975540
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/CandidateSetOrdinalIterator.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Found
epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1693975482
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/FacetRecorder.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
benwtrent opened a new pull request, #13615:
URL: https://github.com/apache/lucene/pull/13615
When quantizing vectors in a COSINE vector space, we normalize them.
However, there is a bug when building the quantizer quantiles and we didn't
always use the normalized vectors. Consequently, we
