Re: [PR] Remove unused segNo calculation in IndexWriter.doFlush [lucene]

2024-06-23 Thread via GitHub
vsop-479 commented on code in PR #13491: URL: https://github.com/apache/lucene/pull/13491#discussion_r1650283929 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -4271,12 +4271,7 @@ private boolean doFlush(boolean applyAllDeletes) throws IOException {

Re: [PR] TaskExecutor should not fork unnecessarily [lucene]

2024-06-23 Thread via GitHub
mikemccand commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2185019080 I've opened https://github.com/mikemccand/luceneutil/issues/275 to close the traps in `luceneutil` when testing concurrent search. -- This is an automated message from the Apache Gi

Re: [PR] TaskExecutor should not fork unnecessarily [lucene]

2024-06-23 Thread via GitHub
mikemccand commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2185015445 > So searching concurrently results in a lot more duplicate work. Thanks @jpountz -- I had actually not realized this. I thought concurrent search exchanged information across