Re: [I] Support for criteria based DWPT selection inside DocumentWriter [lucene]

2024-06-02 Thread via GitHub
jpountz commented on issue #13387: URL: https://github.com/apache/lucene/issues/13387#issuecomment-2144402163 > However, implementing this approach would lead to significant overhead on the client side (such as OpenSearch) both in the terms of code changes and operational overhead like meta

Re: [I] Support for criteria based DWPT selection inside DocumentWriter [lucene]

2024-06-02 Thread via GitHub
RS146BIJAY commented on issue #13387: URL: https://github.com/apache/lucene/issues/13387#issuecomment-2144396439 Attaching a [preliminary PR](https://github.com/apache/lucene/pull/13409) for the POC related to above issue to share my understanding. Please note that this is not the final PR.

Re: [I] Support for criteria based DWPT selection inside DocumentWriter [lucene]

2024-06-02 Thread via GitHub
RS146BIJAY commented on issue #13387: URL: https://github.com/apache/lucene/issues/13387#issuecomment-2144392824 Attaching a [preliminary PR](https://github.com/apache/lucene/pull/13409) for the POC related to above issue to share my understanding. Please note that this is not the final PR.

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-06-02 Thread via GitHub
vsop-479 commented on code in PR #13359: URL: https://github.com/apache/lucene/pull/13359#discussion_r1623732526 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java: ## @@ -307,6 +309,30 @@ private boolean setEOF() { return true; }

Re: [PR] Convert more classes to record classes [lucene]

2024-06-02 Thread via GitHub
shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623687790 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java: ## @@ -447,14 +446,8 @@ private static int commonCharacterPositio

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-06-02 Thread via GitHub
vsop-479 commented on code in PR #13359: URL: https://github.com/apache/lucene/pull/13359#discussion_r1623732526 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java: ## @@ -307,6 +309,30 @@ private boolean setEOF() { return true; }

Re: [PR] Fix test failure on TestPoint#testEqualsAndHashCode [lucene]

2024-06-02 Thread via GitHub
easyice merged PR #13433: URL: https://github.com/apache/lucene/pull/13433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix test failure on TestPoint#testEqualsAndHashCode [lucene]

2024-06-02 Thread via GitHub
easyice commented on PR #13433: URL: https://github.com/apache/lucene/pull/13433#issuecomment-2144176070 Thanks for reviewing, Mike! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Convert more classes to record classes [lucene]

2024-06-02 Thread via GitHub
shubhamvishu commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2144096151 Hi @uschindler , thanks for the review. I took another pass at the changes and pushed some commits addressing your comments. Please have a look when you get a chance. Thanks! --

Re: [PR] Convert more classes to record classes [lucene]

2024-06-02 Thread via GitHub
shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623688659 ## lucene/core/src/java/org/apache/lucene/document/NearestNeighbor.java: ## @@ -34,20 +34,16 @@ /** KNN search on top of 2D lat/lon indexed points. */ class Nea

Re: [PR] Convert more classes to record classes [lucene]

2024-06-02 Thread via GitHub
shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623688408 ## lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/OrdsBlockTreeTermsWriter.java: ## @@ -139,18 +139,17 @@ public final class OrdsBlockTreeTermsWrit

Re: [PR] Convert more classes to record classes [lucene]

2024-06-02 Thread via GitHub
shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623688124 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/TermAndBoost.java: ## @@ -18,14 +18,13 @@ import org.apache.lucene.util.BytesRef

Re: [PR] Convert more classes to record classes [lucene]

2024-06-02 Thread via GitHub
shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623687790 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java: ## @@ -447,14 +446,8 @@ private static int commonCharacterPositio

Re: [PR] Rewrite LongRange.ValueSourceQuery/MultiValueSourceQuery to FieldExistsQuery on max range [lucene]

2024-06-02 Thread via GitHub
github-actions[bot] commented on PR #13383: URL: https://github.com/apache/lucene/pull/13383#issuecomment-2144077592 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Improve BaseRangeFieldQueryTestCase#verify failure output [lucene]

2024-06-02 Thread via GitHub
github-actions[bot] commented on PR #13382: URL: https://github.com/apache/lucene/pull/13382#issuecomment-2144077619 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] TestIDVersionPostingsFormat.testGlobalVersions FAILED maxSeqNo must be greater or equal to 4204 but was 4203 [lucene]

2024-06-02 Thread via GitHub
benwtrent closed issue #13446: TestIDVersionPostingsFormat.testGlobalVersions FAILED maxSeqNo must be greater or equal to 4204 but was 4203 URL: https://github.com/apache/lucene/issues/13446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] TestIDVersionPostingsFormat.testGlobalVersions FAILED maxSeqNo must be greater or equal to 4204 but was 4203 [lucene]

2024-06-02 Thread via GitHub
benwtrent commented on issue #13446: URL: https://github.com/apache/lucene/issues/13446#issuecomment-2143853261 Closing as duplicate: https://github.com/apache/lucene/issues/13127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[I] TestIDVersionPostingsFormat.testGlobalVersions FAILED maxSeqNo must be greater or equal to 4204 but was 4203 [lucene]

2024-06-02 Thread via GitHub
ChrisHegarty opened a new issue, #13446: URL: https://github.com/apache/lucene/issues/13446 This doesn't reproduce for me, even with several 100 iterations of the test. But filing this issue to track any observed failures. ``` ./gradlew test --tests TestIDVersionPostingsFormat.test