Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-05-25 Thread via GitHub
navneet1v commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2132065571 @benwtrent I see that with this PR and enabled the flat vectors format easier to extend. You showed it with an example for BitVectorsFormat. 1. Does this mean now Lucene supports Bi

Re: [I] What does the Lucene community think about dimensionality reduction for vectors, and should it be something the library does internally (at merge time perhaps)? [lucene]

2024-05-25 Thread via GitHub
navneet1v commented on issue #13403: URL: https://github.com/apache/lucene/issues/13403#issuecomment-2132043000 +1 on the idea of bringing the dimensionality reduction technique in Lucene. One problem though I have seen with PQ is you need to have enough number of vectors to build the codeb

Re: [PR] Early terminate visit BKD leaf when current value greater than upper point in sorted dim. [lucene]

2024-05-25 Thread via GitHub
github-actions[bot] commented on PR #12528: URL: https://github.com/apache/lucene/pull/12528#issuecomment-2131779799 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] gh-13147: use dense bit-encoding for frequent terms [lucene]

2024-05-25 Thread via GitHub
github-actions[bot] commented on PR #13153: URL: https://github.com/apache/lucene/pull/13153#issuecomment-2131778403 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Add support for reloading the SPI for KnnVectorsFormat class [lucene]

2024-05-25 Thread via GitHub
navneet1v commented on issue #13393: URL: https://github.com/apache/lucene/issues/13393#issuecomment-2131437707 @benwtrent , @ChrisHegarty as we are not inclined that this is a valid usecase, can you guys please review the PR https://github.com/apache/lucene/pull/13394 -- This i

Re: [PR] Replace Map by CharObjectHashMap and Set by CharHashSet. [lucene]

2024-05-25 Thread via GitHub
dweiss commented on code in PR #13420: URL: https://github.com/apache/lucene/pull/13420#discussion_r1614842290 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseHiraganaUppercaseFilter.java: ## @@ -30,25 +30,15 @@ * legal, contract policies, etc. */

[PR] Replace Map by CharObjectHashMap and Set by CharHashSet. [lucene]

2024-05-25 Thread via GitHub
bruno-roustant opened a new pull request, #13420: URL: https://github.com/apache/lucene/pull/13420 This is my last round of adding primitive structures to the HPPC fork, and using them to gain memory on various locations. No functional change, only optimization. In JapaneseKatakana

Re: [PR] Replace List by IntArrayList and List by LongArrayList. [lucene]

2024-05-25 Thread via GitHub
bruno-roustant merged PR #13406: URL: https://github.com/apache/lucene/pull/13406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@luc

Re: [I] Remove Scorer#getWeight. [lucene]

2024-05-25 Thread via GitHub
romseygeek commented on issue #13410: URL: https://github.com/apache/lucene/issues/13410#issuecomment-2131369881 +1 I'd also look at removing Scorable.getChildren() which we use in a few tests in tandem with getWeight(). We now have several composite scorer implementations that don'