[PR] Fix numDeletesToMerge for unchanged segments [lucene]

2024-04-28 Thread via GitHub
dnhatn opened a new pull request, #13324: URL: https://github.com/apache/lucene/pull/13324 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Support for building materialized views using Lucene formats [lucene]

2024-04-28 Thread via GitHub
jpountz commented on issue #13188: URL: https://github.com/apache/lucene/issues/13188#issuecomment-2081658301 It's not clear to me how we'd take advantage of this information at search time. What changes would we make to e.g. `Collector` to allow it to take advantage of these new data struc

Re: [PR] Make Weight#scorerSupplier abstract, Weight#scorer final [lucene]

2024-04-28 Thread via GitHub
jpountz commented on code in PR #13319: URL: https://github.com/apache/lucene/pull/13319#discussion_r1582371473 ## lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java: ## @@ -136,7 +136,18 @@ public float matchCost() { } };

Re: [I] Can IndexSearcher enable search concurrency by default? [LUCENE-10487] [lucene]

2024-04-28 Thread via GitHub
jpountz commented on issue #11523: URL: https://github.com/apache/lucene/issues/11523#issuecomment-2081644183 Optimistically adding this issue to the 10.0 milestone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] [lucene]

2024-04-28 Thread via GitHub
jpountz commented on issue #9721: URL: https://github.com/apache/lucene/issues/9721#issuecomment-2081643392 > but I guess as an execution strategy it kind of made sense to me -- is it really necessary to clone Scorers? Could we create new ones for each searcher-segment or do we think that i

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-28 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1582091772 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-28 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1582091772 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-28 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1582091772 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde