Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Binary search all terms. [lucene]

2024-04-25 Thread via GitHub
vsop-479 commented on code in PR #13192: URL: https://github.com/apache/lucene/pull/13192#discussion_r1543119650 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -196,6 +207,90 @@ void loadBlock() throws IOException { suf

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1580286445 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] [LUCENE-13044][replicator] NRT add configurable commitData for Custom… [lucene]

2024-04-25 Thread via GitHub
github-actions[bot] commented on PR #13045: URL: https://github.com/apache/lucene/pull/13045#issuecomment-2078378730 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Improve int4 compressed comparisons performance [lucene]

2024-04-25 Thread via GitHub
rmuir commented on PR #13321: URL: https://github.com/apache/lucene/pull/13321#issuecomment-2078163094 panama logic looks good to me. Not for this PR, just a question, is it possible to use this same trick for 8 bit integer calculations too? I imagine this trick could probably help there as

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-04-25 Thread via GitHub
dweiss commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2078091483 > Any thoughts on whether queryParser.parse( "[ a\\[i\\] TO b\\[i\\] ]" ); should work? I did play around with updating the grammar, it should be possible but I need to think more about h

Re: [I] Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] [lucene]

2024-04-25 Thread via GitHub
msokolov commented on issue #9721: URL: https://github.com/apache/lucene/issues/9721#issuecomment-2078043920 but I guess as an execution strategy it kind of made sense to me -- is it really necessary to clone Scorers? Could we create new ones for each searcher-segment or do we think that is

Re: [I] Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] [lucene]

2024-04-25 Thread via GitHub
msokolov commented on issue #9721: URL: https://github.com/apache/lucene/issues/9721#issuecomment-2078030793 I started to play around with a hacky implementation that: 1. adds docid interval [start, end] to `LeafReaderContext` 2. modifies IndexSearcher so it creates these "searcher"

Re: [PR] Improve int4 compressed comparisons performance [lucene]

2024-04-25 Thread via GitHub
ChrisHegarty commented on PR #13321: URL: https://github.com/apache/lucene/pull/13321#issuecomment-2077675140 > Because this makes things measurably slower. .. Ok. That's a very good reason! ;-) > And I am not sure how it makes the comparisons easier. We then have to add LoC to

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
benwtrent commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579769524 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Index

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579596679 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579596679 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579596679 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579596679 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579458103 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579458103 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579596679 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579596679 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579458103 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579458103 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Improve int4 compressed comparisons performance [lucene]

2024-04-25 Thread via GitHub
benwtrent commented on code in PR #13321: URL: https://github.com/apache/lucene/pull/13321#discussion_r1579422728 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -179,7 +179,30 @@ public static int int4DotProduct(byte[] a, byte[] b) { if (a.length != b

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
benwtrent commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579341971 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Index

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579285322 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579285322 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579285322 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579285322 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579285322 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [I] Query parser fails to parse a range query string when there are escaped brackets inside the range [lucene]

2024-04-25 Thread via GitHub
marko-bekhta commented on issue #13234: URL: https://github.com/apache/lucene/issues/13234#issuecomment-2076897782 Thanks for looking at this and for the suggestion! I've also tested it out and can confirm that it worked. I'll let you decide how you'd want to proceed with this ticket (lo

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579173947 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579173947 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Improve int4 compressed comparisons performance [lucene]

2024-04-25 Thread via GitHub
ChrisHegarty commented on code in PR #13321: URL: https://github.com/apache/lucene/pull/13321#discussion_r1579117412 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -179,7 +179,30 @@ public static int int4DotProduct(byte[] a, byte[] b) { if (a.length !

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579103250 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-25 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1579103250 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde