Re: [PR] Don't assume non-zero aggregations in getTopDims or test checkResults [lucene]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #13287: URL: https://github.com/apache/lucene/pull/13287#issuecomment-2076082734 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Integrate merge-time index reordering with the intra-merge executor. [lucene]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #13289: URL: https://github.com/apache/lucene/pull/13289#issuecomment-2076082702 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Query parser fails to parse a range query string when there are escaped brackets inside the range [lucene]

2024-04-24 Thread via GitHub
benchaplin commented on issue #13234: URL: https://github.com/apache/lucene/issues/13234#issuecomment-2076083215 You can get around this by placing each range term in quotes: ```java query = queryParser.parse( "[ \"2024\\-01\\-01T01\\:01\\:01\\+01\\:00\\[Europe\\/Warsaw\\]\" TO \"

Re: [PR] Add WrappedCandidateMatcher for composing matchers [lucene]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #13109: URL: https://github.com/apache/lucene/pull/13109#issuecomment-2076083082 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix TestTaxonomyFacetValueSource.testRandom [lucene]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #13198: URL: https://github.com/apache/lucene/pull/13198#issuecomment-2076082854 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Add test for parsing brackets in range queries [lucene]

2024-04-24 Thread via GitHub
benchaplin opened a new pull request, #13323: URL: https://github.com/apache/lucene/pull/13323 ### Description I've added some unit tests to protect/display the QueryParser's ability to parse brackets in range query terms when in quotes. [This issue](https://github.com/apache/l

Re: [PR] Add timeout support to AbstractVectorSimilarityQuery [lucene]

2024-04-24 Thread via GitHub
kaivalnp commented on PR #13285: URL: https://github.com/apache/lucene/pull/13285#issuecomment-2075846511 Thanks @benwtrent! Added an entry now.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add timeout support to AbstractVectorSimilarityQuery [lucene]

2024-04-24 Thread via GitHub
benwtrent commented on PR #13285: URL: https://github.com/apache/lucene/pull/13285#issuecomment-2075661472 @kaivalnp could you update CHANGES as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add timeout support to AbstractVectorSimilarityQuery [lucene]

2024-04-24 Thread via GitHub
benwtrent commented on PR #13285: URL: https://github.com/apache/lucene/pull/13285#issuecomment-2075660880 This seems sane to me. @vigyasharma what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-24 Thread via GitHub
benwtrent commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1578336720 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Index

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-24 Thread via GitHub
benwtrent commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1578328936 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Index

Re: [I] Support for building materialized views using Lucene formats [lucene]

2024-04-24 Thread via GitHub
bharath-techie commented on issue #13188: URL: https://github.com/apache/lucene/issues/13188#issuecomment-2075553304 Thanks for the comments @msfroh . Good idea, if we want to supply `Dims` and `metric` values to `DataCubesWriter` as part of `addDocument` flow and consume them similar

Re: [PR] Implement Weight#count for vector values in the FieldExistsQuery [lucene]

2024-04-24 Thread via GitHub
benwtrent commented on PR #13322: URL: https://github.com/apache/lucene/pull/13322#issuecomment-2075509191 I like this. Could you add an entry under "Optimizations" in "CHANGES.txt"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Improve int4 compressed comparisons performance [lucene]

2024-04-24 Thread via GitHub
benwtrent commented on code in PR #13321: URL: https://github.com/apache/lucene/pull/13321#discussion_r1577962121 ## lucene/core/src/test/org/apache/lucene/codecs/lucene99/TestLucene99ScalarQuantizedVectorScorer.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

Re: [PR] Improve int4 compressed comparisons performance [lucene]

2024-04-24 Thread via GitHub
ChrisHegarty commented on code in PR #13321: URL: https://github.com/apache/lucene/pull/13321#discussion_r1577918752 ## lucene/core/src/java/org/apache/lucene/util/hnsw/RandomAccessVectorValues.java: ## @@ -72,6 +84,11 @@ interface Floats extends RandomAccessVectorValues {

Re: [PR] Avoid SegmentTermsEnumFrame reload block. [lucene]

2024-04-24 Thread via GitHub
vsop-479 commented on PR #13253: URL: https://github.com/apache/lucene/pull/13253#issuecomment-2074244391 > This might be a needle-moving optimization for apps that reuse a single TermsEnum and seek randomly to terms, right? Yes. > Because all up and down the stack of SegmentTe