Re: [PR] Remove unnecessary assert and fix comment in SegmentTermsEnumFrame [lucene]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #13279: URL: https://github.com/apache/lucene/pull/13279#issuecomment-2071161268 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-22 Thread via GitHub
benwtrent commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1575385344 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestInt8HnswBackwardsCompatibility.java: ## @@ -50,8 +51,14 @@ public class TestInt8HnswBackwards

Re: [PR] Adding binary Hamming distance as similarity option for byte vectors [lucene]

2024-04-22 Thread via GitHub
benwtrent commented on PR #13076: URL: https://github.com/apache/lucene/pull/13076#issuecomment-2070929625 Closing in deference to extensibility added in: https://github.com/apache/lucene/pull/13288 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Adding binary Hamming distance as similarity option for byte vectors [lucene]

2024-04-22 Thread via GitHub
benwtrent closed pull request #13076: Adding binary Hamming distance as similarity option for byte vectors URL: https://github.com/apache/lucene/pull/13076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Making vector comparisons pluggable [lucene]

2024-04-22 Thread via GitHub
benwtrent closed issue #13182: Making vector comparisons pluggable URL: https://github.com/apache/lucene/issues/13182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] Making vector comparisons pluggable [lucene]

2024-04-22 Thread via GitHub
benwtrent commented on issue #13182: URL: https://github.com/apache/lucene/issues/13182#issuecomment-2070929391 Closing as fixed by https://github.com/apache/lucene/pull/13288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [Backport] Add BitVectors format and make flat vectors format easier to extend (#13288) [lucene]

2024-04-22 Thread via GitHub
benwtrent merged PR #13316: URL: https://github.com/apache/lucene/pull/13316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-22 Thread via GitHub
benwtrent commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1574674149 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -177,7 +180,6 @@ public boolean test(LeafReaderContext context) { * @lucene.experiment

Re: [I] Support for building materialized views using Lucene formats [lucene]

2024-04-22 Thread via GitHub
bharath-techie commented on issue #13188: URL: https://github.com/apache/lucene/issues/13188#issuecomment-2068963512 ### DataCubesFormat ``` public abstract class DataCubesFormat implements NamedSPILoader.NamedSPI { /** * Returns producer to read the data cube

Re: [I] Support for building materialized views using Lucene formats [lucene]

2024-04-22 Thread via GitHub
bharath-techie commented on issue #13188: URL: https://github.com/apache/lucene/issues/13188#issuecomment-2068945005 There are several advantages to keeping the new index as part of the same Lucene segment. It reduces maintenance overhead and enables Near Real-Time (NRT) use cases. Specific

Re: [I] Reproducible test failure in TestLucene90FieldInfosFormat.testRandom [lucene]

2024-04-22 Thread via GitHub
stefanvodita closed issue #13129: Reproducible test failure in TestLucene90FieldInfosFormat.testRandom URL: https://github.com/apache/lucene/issues/13129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix TestLucene90FieldInfosFormat.testRandom [lucene]

2024-04-22 Thread via GitHub
stefanvodita merged PR #13135: URL: https://github.com/apache/lucene/pull/13135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

2024-04-22 Thread via GitHub
vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1574272996 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef targ