Re: [I] [DISCUSS] Identifying Gaps in Lucene’s Faceting [lucene]

2024-04-21 Thread via GitHub
sandeshkr419 commented on issue #12553: URL: https://github.com/apache/lucene/issues/12553#issuecomment-2068393874 Thanks @stefanvodita, @Shradha26 for doing a thorough review of gaps with Lucene's faceting. I think that in summary, this is leaning in towards support for aggregation capabil

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-21 Thread via GitHub
Pulkitg64 commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1573864798 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -302,7 +301,6 @@ private static VectorSimilarityFunction getDistFunc(

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-21 Thread via GitHub
Pulkitg64 commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1573864798 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -302,7 +301,6 @@ private static VectorSimilarityFunction getDistFunc(

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-21 Thread via GitHub
Pulkitg64 commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1573864798 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -302,7 +301,6 @@ private static VectorSimilarityFunction getDistFunc(

[PR] Remove unnecessary bit conversion for IndexSorter [lucene]

2024-04-21 Thread via GitHub
bugmakerr opened a new pull request, #13320: URL: https://github.com/apache/lucene/pull/13320 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Align toString methods in geo module [lucene]

2024-04-21 Thread via GitHub
timgrein commented on code in PR #13302: URL: https://github.com/apache/lucene/pull/13302#discussion_r1573819261 ## lucene/core/src/java/org/apache/lucene/geo/XYPolygon.java: ## @@ -187,6 +187,7 @@ public boolean equals(Object obj) { @Override public String toString() {