Re: [PR] Add timeout support to AbstractKnnVectorQuery [lucene]

2024-04-14 Thread via GitHub
kaivalnp commented on PR #13202: URL: https://github.com/apache/lucene/pull/13202#issuecomment-2055680667 FYI I opened #13285 to add the same timeout support to `AbstractVectorSimilarityQuery` -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Use Float.compare instead of '==' in XYPoint and XYCircle [lucene]

2024-04-14 Thread via GitHub
timgrein commented on PR #13301: URL: https://github.com/apache/lucene/pull/13301#issuecomment-2055667053 > Thanks for looking into this! I found more classes like `Point`, `Circle`, `Rectangle2D` using `==` for `equals`, their hashcode will also different between `0.0` and `-0.0`, do they

Re: [PR] Use Float.compare instead of '==' in XYPoint and XYCircle [lucene]

2024-04-14 Thread via GitHub
easyice commented on PR #13301: URL: https://github.com/apache/lucene/pull/13301#issuecomment-2054287978 Thanks for looking into this! I found more classes like `Point`, `Circle`, `Rectangle2D` using `==` for `equals`, their hashcode will also different between `0.0` and `-0.0`, do the

[PR] Align toString methods in geo module [lucene]

2024-04-14 Thread via GitHub
timgrein opened a new pull request, #13302: URL: https://github.com/apache/lucene/pull/13302 ### Description Some `toString` methods in the `geo` module sometimes use uppercase or the class name. I've aligned them to use always the class name. -- This is an automated message from t