Re: [PR] Fix TestTaxonomyFacetValueSource.testRandom [lucene]

2024-04-09 Thread via GitHub
iamsanjay commented on PR #13198: URL: https://github.com/apache/lucene/pull/13198#issuecomment-2046550816 > @iamsanjay - thank you for working on this! I merged #12966, which should mean the original test failure is fixed. Do you want to verify that all is working as expected now? I

[PR] GitHub 13262 remove deprecated code [lucene]

2024-04-09 Thread via GitHub
iamsanjay opened a new pull request, #13286: URL: https://github.com/apache/lucene/pull/13286 ### Description closes #13262 Additionally I removed deprecated code from two more classes: VH_BE_DOUBLE (static memeber in BitUtil) and variant of BlockJoinSelector.wrap meth

Re: [PR] Fix TestIndexWriter.testDeleteUnusedFiles' failure on Windows 11 [lucene]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #13183: URL: https://github.com/apache/lucene/pull/13183#issuecomment-2046234438 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #12862: URL: https://github.com/apache/lucene/pull/12862#issuecomment-2046235004 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Reduce ArrayUtil#grow in decompress [lucene]

2024-04-09 Thread via GitHub
vigyasharma commented on PR #12996: URL: https://github.com/apache/lucene/pull/12996#issuecomment-2046157819 @jpountz my bad, I think I missed the back-port. Merged it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-09 Thread via GitHub
benwtrent commented on code in PR #13283: URL: https://github.com/apache/lucene/pull/13283#discussion_r1558261300 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -786,9 +830,9 @@ public void testTimeout() throws IOException { assert

Re: [PR] Schedule compileJava after the internal task if it affects source files [lucene]

2024-04-09 Thread via GitHub
dweiss commented on PR #13282: URL: https://github.com/apache/lucene/pull/13282#issuecomment-2045921017 No problem at all. I really wish this could be done simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-09 Thread via GitHub
kaivalnp commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2045841382 Ah thanks! I fixed and unmuted [one](https://github.com/apache/lucene/blob/26fe2c4b9ca13e7930b818033a04094a5f44d574/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCa

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-09 Thread via GitHub
vigyasharma commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2045746855 Let us also [unmute](https://github.com/apache/lucene/pull/13273) the broken tests as part of this change? -- This is an automated message from the Apache Git Service. To respond t

Re: [I] Multi-value Support for KnnVectorField [lucene]

2024-04-09 Thread via GitHub
benwtrent commented on issue #12313: URL: https://github.com/apache/lucene/issues/12313#issuecomment-2045722371 > if the aggregation is max, would we need to compute distance between n x n vectors and then take the max? Correct, I would even want flexibility between what was used to

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-09 Thread via GitHub
mayya-sharipova commented on code in PR #13268: URL: https://github.com/apache/lucene/pull/13268#discussion_r1558043257 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -712,17 +712,21 @@ public String[] highlight(String field, Qu

Re: [I] Multi-value Support for KnnVectorField [lucene]

2024-04-09 Thread via GitHub
vigyasharma commented on issue #12313: URL: https://github.com/apache/lucene/issues/12313#issuecomment-2045706297 @benwtrent : ++, I've been thinking on similar lines in the context of e-commerce type applications where different vectors represent different aspects of a document. The scorer

Re: [I] Multi-value Support for KnnVectorField [lucene]

2024-04-09 Thread via GitHub
benwtrent commented on issue #12313: URL: https://github.com/apache/lucene/issues/12313#issuecomment-2045604262 I do think things like `ColBERT` would benefit from having multiple vectors for a single document field. One crazy idea I had (others have probably already thought of this,

Re: [PR] Reduce ArrayUtil#grow in decompress [lucene]

2024-04-09 Thread via GitHub
jpountz commented on PR #12996: URL: https://github.com/apache/lucene/pull/12996#issuecomment-2045452091 @vigyasharma I wonder if you missed to backport this change to `branch_9x`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Move per-field vector and doc-values readers from TreeMap to HashMap. [lucene]

2024-04-09 Thread via GitHub
jpountz merged PR #13284: URL: https://github.com/apache/lucene/pull/13284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Schedule compileJava after the internal task if it affects source files [lucene]

2024-04-09 Thread via GitHub
rmuir commented on PR #13282: URL: https://github.com/apache/lucene/pull/13282#issuecomment-2045163658 thank you again for wrestling this down with build magic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Add timeout support to AbstractVectorSimilarityQuery [lucene]

2024-04-09 Thread via GitHub
kaivalnp opened a new pull request, #13285: URL: https://github.com/apache/lucene/pull/13285 ### Description Along similar lines of #13202, adding timeout support for [`AbstractVectorSimilarityQuery`](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/se

Re: [I] Multi-value Support for KnnVectorField [lucene]

2024-04-09 Thread via GitHub
alessandrobenedetti commented on issue #12313: URL: https://github.com/apache/lucene/issues/12313#issuecomment-2044685997 Hi, I gave a talk about this at Berlin Buzzwords where I touched on the motivations: https://www.youtube.com/watch?v=KhL0NrGj0uE In short: - multi-valued vectors